Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Onboard sync stack for Identity package #34846

Conversation

maximrytych-ms
Copy link
Member

@maximrytych-ms maximrytych-ms commented May 9, 2023

Description

Onboarded sync stack:

  • CommunicationIdentitiesImpl regenerated with new sync overloads
  • Test updated with AssertingHttpClientBuilder to assert a/sync processing
  • Updated test records

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@azure-sdk
Copy link
Collaborator

API change check

API changes are not detected in this pull request.

@AikoBB
Copy link
Member

AikoBB commented May 15, 2023

/azp run java - azure-communication-identity - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Member

@AikoBB AikoBB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, though tests need refactoring...pls mentions the issue in your PR and let the eng.sys team that the work is completed for communication-identity package

@AikoBB AikoBB merged commit 1eb120a into Azure:main May 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants