[Purview-Workflow][TestProxyMigration] Enable disabled tests and re-record #36021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mssfang
added
Client
mssfang
requested review from
joshfree,
srnagar,
anuchandy,
conniey,
lmolkova and
JonathanGiles
as code owners
|
API change check API changes are not detected in this pull request. |
samvaity
approved these changes
Jul 21, 2023
| @@ -37,7 +36,14 @@ protected void beforeTest() { | |||
| } else { | |||
| purviewWorkflowClientbuilder | |||
| .httpClient(HttpClient.createDefault()) | |||
| .credential(new DefaultAzureCredentialBuilder().build()); | |||
| .credential(new UsernamePasswordCredentialBuilder() | |||
| .clientId(Configuration.getGlobalConfiguration().get("CLIENTID", "clientId")) | |||
There was a problem hiding this comment.
Should these be named AZURE_CLIENT_ID etc..
There was a problem hiding this comment.
It is what the SDK owner uses. I would stay with what it is until they change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up PR: #36005
fix: #36007