-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Minor tracing samples improvements #36226
Minor tracing samples improvements #36226
Conversation
@trask, could you please take a look? |
API change check API changes are not detected in this pull request. |
what do you think of using the autoconfigure module now that it's been recently declared stable? (it adds JVM shutdown hook that calls flush) I tried it out here: trask@be1639f |
I like it much better, I tried running the CI against your commit there are no errors about dependencies from autoconfigure (that we've seen before), just the info message
I'll cherry-pick your commit and add a banned dependency then. Thank you! |
29ed7d1
to
5cda01d
Compare
...zure/core/tracing/opentelemetry/samples/CreateConfigurationSettingLoggingExporterSample.java
Outdated
Show resolved
Hide resolved
efa2f6d
to
f2001d7
Compare
Random improvements: