Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor tracing samples improvements #36226

Merged
merged 4 commits into from
Sep 27, 2023

Conversation

lmolkova
Copy link
Member

@lmolkova lmolkova commented Aug 2, 2023

Random improvements:

@lmolkova
Copy link
Member Author

lmolkova commented Aug 2, 2023

@trask, could you please take a look?

@github-actions github-actions bot added the Azure.Core azure-core label Aug 2, 2023
@azure-sdk
Copy link
Collaborator

API change check

API changes are not detected in this pull request.

@trask
Copy link
Member

trask commented Aug 3, 2023

what do you think of using the autoconfigure module now that it's been recently declared stable?

(it adds JVM shutdown hook that calls flush)

I tried it out here: trask@be1639f

@lmolkova
Copy link
Member Author

lmolkova commented Aug 3, 2023

what do you think of using the autoconfigure module now that it's been recently declared stable?

I like it much better, I tried running the CI against your commit

https://dev.azure.com/azure-sdk/public/_build/results?buildId=2974233&view=logs&j=056e4f97-65fc-5f8c-9394-2f5e3fb7987c&t=ce901df3-f7be-50f6-3b4e-d889e48a7388

there are no errors about dependencies from autoconfigure (that we've seen before), just the info message

Aug 03, 2023 4:38:45 PM io.opentelemetry.api.GlobalOpenTelemetry maybeAutoConfigureAndSetGlobal
INFO: AutoConfiguredOpenTelemetrySdk found on classpath but automatic configuration is disabled. To enable, run your JVM with -Dotel.java.global-autoconfigure.enabled=true

I'll cherry-pick your commit and add a banned dependency then. Thank you!

@joshfree joshfree added this to the 2023-10 milestone Aug 30, 2023
@lmolkova lmolkova force-pushed the tracing-samples-minor-improvements branch from 29ed7d1 to 5cda01d Compare September 26, 2023 22:03
@lmolkova lmolkova enabled auto-merge (squash) September 26, 2023 22:07
@lmolkova lmolkova force-pushed the tracing-samples-minor-improvements branch from efa2f6d to f2001d7 Compare September 27, 2023 20:30
@lmolkova lmolkova merged commit a562e65 into Azure:main Sep 27, 2023
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Azure.Core azure-core
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants