Eg sync stack testproxy #36656
Merged
Eg sync stack testproxy #36656
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes Azure#34733 For our dev time credentials we want to always keep going. This change wraps any failure from the credentials in a `CredentialUnavailableException` so `ChainedTokenCredential` will continue them properly. It only does so in the context of a `ChainedTokenCredential`. Regular uses of these credentials is unaffected.
joshfree
reviewed
Sep 7, 2023
samvaity
approved these changes
Sep 12, 2023
|
|
||
| private HttpClient buildAssertingClient(HttpClient httpClient, boolean sync) { | ||
| AssertingHttpClientBuilder builder = new AssertingHttpClientBuilder(httpClient) | ||
| .skipRequest((ignored1, ignored2) -> false); |
|
API change check APIView has identified API level changes in this PR and created following API reviews. |
samvaity
reviewed
Sep 14, 2023
...ty/azure-identity/src/main/java/com/azure/identity/implementation/IdentityClientOptions.java
Outdated
Show resolved
Hide resolved
billwert
force-pushed
the
eg-sync-stack-testproxy
branch
from
d50b0b7 to
7d2ed33
Compare
billwert
force-pushed
the
eg-sync-stack-testproxy
branch
from
bf9305e to
b4bcd9d
Compare
srnagar
force-pushed
the
eg-sync-stack-testproxy
branch
from
b4bcd9d to
10da9a6
Compare
Netyyyy
reviewed
Oct 13, 2023
| @@ -177,7 +177,7 @@ | |||
| <dependency> | |||
| <groupId>com.azure</groupId> | |||
| <artifactId>azure-messaging-eventgrid</artifactId> | |||
| <version>4.18.0</version> <!-- {x-version-update;com.azure:azure-messaging-eventgrid;dependency} --> | |||
| <version>4.19.0-beta.1</version> <!-- {x-version-update;unreleased_com.azure:azure-messaging-eventgrid;dependency} --> | |||
There was a problem hiding this comment.
Hi @billwert @srnagar, will these changes be changed back after release?
FYI: @saragluna
There was a problem hiding this comment.
yes, these changes will be updated to use the released dependency after the release of azure-messaging-eventgrid. It will not be shipped with unreleased dependency.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.