Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Organize the Spring directory #36692

Merged
merged 3 commits into from
Sep 12, 2023
Merged

Conversation

Netyyyy
Copy link
Member

@Netyyyy Netyyyy commented Sep 11, 2023

Description

Organize the Spring directory:

  1. move xxx-tests-job.yml into spring/pipeline
  2. move xxx-matrix.json into spring/pipeline
  3. move spring-cloud-azure-supported-spring.json into spring/pipeline

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@Netyyyy
Copy link
Member Author

Netyyyy commented Sep 11, 2023

/azp run java - spring - tests

@github-actions github-actions bot added the azure-spring All azure-spring related issues label Sep 11, 2023
@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@Netyyyy
Copy link
Member Author

Netyyyy commented Sep 11, 2023

/azp run java - spring-monitor - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Co-authored-by: Xiaolu Dai <31124698+saragluna@users.noreply.github.com>
@Netyyyy
Copy link
Member Author

Netyyyy commented Sep 12, 2023

/check-enforcer override

@Netyyyy Netyyyy enabled auto-merge (squash) September 12, 2023 02:12
@Netyyyy
Copy link
Member Author

Netyyyy commented Sep 12, 2023

/check-enforcer override

@Netyyyy Netyyyy marked this pull request as draft September 12, 2023 05:52
auto-merge was automatically disabled September 12, 2023 05:52

Pull request was converted to draft

@Netyyyy Netyyyy marked this pull request as ready for review September 12, 2023 05:53
@Netyyyy Netyyyy marked this pull request as draft September 12, 2023 05:55
@Netyyyy Netyyyy marked this pull request as ready for review September 12, 2023 06:40
@Netyyyy Netyyyy merged commit eaa16d1 into Azure:main Sep 12, 2023
@kushagraThapar
Copy link
Member

@saragluna / @Netyyyy - when we change any spring-data-cosmos related code, please make sure to run the cosmos ci, and spring-data-cosmos CI pipelines to validate the change.
Looks like this change broke the cosmos CI pipelines that runs spring data cosmos CI. https://dev.azure.com/azure-sdk/internal/_build/results?buildId=3077931&view=logs&jobId=8bef1c98-23e3-5d36-ff88-ed7605b6f394

on this PR - #36687 (comment)

@saragluna and @Netyyyy , please work with @xinlian12 to fix this issue as quickly as possible so we can get the coverage back up, thanks!

@Netyyyy Netyyyy deleted the myao/organize_spring_folder branch October 13, 2023 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
azure-spring All azure-spring related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants