Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OpenAI] Add sanitizer for multipart header and record without request body for multipart/form-data #36987

Merged
merged 5 commits into from
Sep 28, 2023

Conversation

mssfang
Copy link
Member

@mssfang mssfang commented Sep 28, 2023

No more hard-coded boundary value but use UUID random generator to generate boundary randomly.

In order to pass the tests in PLAYBACK mode:
(1) Added HEADER sanitizer to sanitize the content-type=multipart/form-data header
(2) Added ignore record request body annotation for multipart/form-data tests

fixes: #36982

@mssfang mssfang added Client This issue points to a problem in the data-plane of the library. OpenAI labels Sep 28, 2023
@mssfang mssfang added this to the 2023-10 milestone Sep 28, 2023
@mssfang mssfang self-assigned this Sep 28, 2023
@mssfang mssfang marked this pull request as ready for review September 28, 2023 01:15
@azure-sdk
Copy link
Collaborator

API change check

API changes are not detected in this pull request.

mssfang and others added 2 commits September 28, 2023 12:26
…penAIClientTestBase.java

Co-authored-by: Sameeksha Vaity <sameeksha.v91@gmail.com>
@mssfang mssfang changed the title [OpenAI] Add sanitizer and ignore request body matcher [OpenAI] Add sanitizer for multipart header and record without request body for multipart/form-data Sep 28, 2023
@mssfang mssfang requested a review from samvaity September 28, 2023 23:26
@mssfang mssfang merged commit e17f1d9 into Azure:main Sep 28, 2023
16 checks passed
@mssfang mssfang deleted the OpenAI-randomUUIDinPlaybackMode branch September 28, 2023 23:40
@mssfang mssfang added OpenAI and removed OpenAI labels Jan 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Client This issue points to a problem in the data-plane of the library. OpenAI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[OpenAI] Support random generated boundary value of multipart/form-data in TestProxy
4 participants