Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding new service version 2024-05-04 (2nd try) #38255

Merged
merged 4 commits into from
Jan 10, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion sdk/storage/azure-storage-blob/assets.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,5 +2,5 @@
"AssetsRepo": "Azure/azure-sdk-assets",
"AssetsRepoPrefixPath": "java",
"TagPrefix": "java/storage/azure-storage-blob",
"Tag": "java/storage/azure-storage-blob_622f991d7c"
"Tag": "java/storage/azure-storage-blob_e8d223adb0"
}
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,12 @@ public enum BlobServiceVersion implements ServiceVersion {
/**
* Service version {@code 2024-02-04}.
*/
V2024_02_04("2024-02-04");
V2024_02_04("2024-02-04"),

/**
* Service version {@code 2024-05-04}.
*/
V2024_05_04("2024-05-04");

private final String version;

Expand All @@ -134,6 +139,6 @@ public String getVersion() {
* @return the latest {@link BlobServiceVersion}
*/
public static BlobServiceVersion getLatest() {
return V2024_02_04;
return V2024_05_04;
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -892,10 +892,10 @@ public void storageAccountAudience() {

@Test
public void audienceError() {
AppendBlobAsyncClient aadBlob = new SpecializedBlobClientBuilder()
AppendBlobAsyncClient aadBlob = instrument(new SpecializedBlobClientBuilder()
.endpoint(bc.getBlobUrl())
.credential(new MockTokenCredential())
.audience(BlobAudience.createBlobServiceAccountAudience("badAudience"))
.audience(BlobAudience.createBlobServiceAccountAudience("badAudience")))
.buildAppendBlobAsyncClient();

StepVerifier.create(aadBlob.exists())
Expand Down
4 changes: 2 additions & 2 deletions sdk/storage/azure-storage-common/ci.system.properties
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
AZURE_LIVE_TEST_SERVICE_VERSION=V2024_02_04
AZURE_STORAGE_SAS_SERVICE_VERSION=2024-02-04
AZURE_LIVE_TEST_SERVICE_VERSION=V2024_05_04
AZURE_STORAGE_SAS_SERVICE_VERSION=2024-05-04
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@ public final class Constants {
public static final String PROPERTY_AZURE_STORAGE_SAS_SERVICE_VERSION = "AZURE_STORAGE_SAS_SERVICE_VERSION";

public static final String SAS_SERVICE_VERSION = Configuration.getGlobalConfiguration()
.get(PROPERTY_AZURE_STORAGE_SAS_SERVICE_VERSION, "2024-02-04");
.get(PROPERTY_AZURE_STORAGE_SAS_SERVICE_VERSION, "2024-05-04");

private Constants() {
}
Expand Down Expand Up @@ -216,7 +216,7 @@ public static final class HeaderConstants {
* @deprecated For SAS Service Version use {@link Constants#SAS_SERVICE_VERSION}.
*/
@Deprecated
public static final String TARGET_STORAGE_VERSION = "2024-02-04";
public static final String TARGET_STORAGE_VERSION = "2024-05-04";

/**
* Error code returned from the service.
Expand Down
2 changes: 1 addition & 1 deletion sdk/storage/azure-storage-file-datalake/assets.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,5 +2,5 @@
"AssetsRepo": "Azure/azure-sdk-assets",
"AssetsRepoPrefixPath": "java",
"TagPrefix": "java/storage/azure-storage-file-datalake",
"Tag": "java/storage/azure-storage-file-datalake_cfa1594c39"
"Tag": "java/storage/azure-storage-file-datalake_454e33b26b"
}
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,12 @@ public enum DataLakeServiceVersion implements ServiceVersion {
/**
* Service version {@code 2024-02-04}.
*/
V2024_02_04("2024-02-04");
V2024_02_04("2024-02-04"),

/**
* Service version {@code 2024-05-04}.
*/
V2024_05_04("2024-05-04");

private final String version;

Expand All @@ -134,6 +139,6 @@ public String getVersion() {
* @return the latest {@link DataLakeServiceVersion}
*/
public static DataLakeServiceVersion getLatest() {
return V2024_02_04;
return V2024_05_04;
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,8 @@ public static BlobServiceVersion toBlobServiceVersion(DataLakeServiceVersion ver
return BlobServiceVersion.V2023_11_03;
} else if (DataLakeServiceVersion.V2024_02_04.ordinal() == version.ordinal()) {
return BlobServiceVersion.V2024_02_04;
} else if (DataLakeServiceVersion.V2024_05_04.ordinal() == version.ordinal()) {
return BlobServiceVersion.V2024_05_04;
}

return null;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -113,7 +113,12 @@ public enum ShareServiceVersion implements ServiceVersion {
/**
* Service version {@code 2024-02-04}.
*/
V2024_02_04("2024-02-04");
V2024_02_04("2024-02-04"),

/**
* Service version {@code 2024-05-04}.
*/
V2024_05_04("2024-05-04");

private final String version;

Expand All @@ -135,6 +140,6 @@ public String getVersion() {
* @return the latest {@link ShareServiceVersion}
*/
public static ShareServiceVersion getLatest() {
return V2024_02_04;
return V2024_05_04;
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,12 @@ public enum QueueServiceVersion implements ServiceVersion {
/**
* Service version {@code 2024-02-04}.
*/
V2024_02_04("2024-02-04");
V2024_02_04("2024-02-04"),

/**
* Service version {@code 2024-05-04}.
*/
V2024_05_04("2024-05-04");

private final String version;

Expand All @@ -134,6 +139,6 @@ public String getVersion() {
* @return the latest {@link QueueServiceVersion}
*/
public static QueueServiceVersion getLatest() {
return V2024_02_04;
return V2024_05_04;
}
}
Loading