Fixed an issue in QuorumReader when quorum could not be selected even though 1 secondary and Primary are reachable and in sync #38832
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to users/fabianm/ReadManyRequestOptions
…sQueryRequestOptions was not final.
…to users/fabianm/QuorumReaderNoQuorumSelected
…to users/fabianm/QuorumReaderNoQuorumSelected
FabianMeiswinkel
requested review from
kushagraThapar,
kirankumarkolli,
xinlian12,
milismsft,
aayush3011,
simorenoh,
jeet1995 and
Pilchie
as code owners
|
/azp run java - cosmos - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run java - cosmos - spark |
|
Azure Pipelines successfully started running 1 pipeline(s). |
xinlian12
approved these changes
Feb 19, 2024
sdk/cosmos/azure-cosmos-tests/src/test/java/com/azure/cosmos/CosmosItemTest.java
Show resolved
Hide resolved
sdk/cosmos/azure-cosmos-tests/src/test/java/com/azure/cosmos/CosmosItemTest.java
Outdated
Show resolved
Hide resolved
|
/azp run java - cosmos - spark |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run java - cosmos - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run java - cosmos - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
tvaron3
pushed a commit
that referenced
this pull request
Apr 23, 2024
… though 1 secondary and Primary are reachable and in sync (#38832) * Added overload with CosmosReadManyRequestOptions * Fixing style errors * Update CosmosReadManyRequestOptions.java * Fixing build break * Avoiding a possibly breaking change by injecting a base class - CosmosQueryRequestOptions was not final. * Update TransientIOErrorsRetryingIteratorITest.scala * Addressing code review feedback * Added fallback to include Primary in QuorumReader when quorum could not be selected. * Update CHANGELOG.md * Update CosmosItemTest.java * Update CosmosItemTest.java
tvaron3
added a commit
that referenced
this pull request
Apr 25, 2024
* Fixed an issue in QuorumReader when quorum could not be selected even though 1 secondary and Primary are reachable and in sync (#38832) * Added overload with CosmosReadManyRequestOptions * Fixing style errors * Update CosmosReadManyRequestOptions.java * Fixing build break * Avoiding a possibly breaking change by injecting a base class - CosmosQueryRequestOptions was not final. * Update TransientIOErrorsRetryingIteratorITest.scala * Addressing code review feedback * Added fallback to include Primary in QuorumReader when quorum could not be selected. * Update CHANGELOG.md * Update CosmosItemTest.java * Update CosmosItemTest.java * increase the version in each module * changed test to use queryOptions instead of readmany options * Update sdk/cosmos/azure-cosmos/CHANGELOG.md * updated date * Update sdk/cosmos/azure-cosmos/CHANGELOG.md --------- Co-authored-by: Fabian Meiswinkel <fabianm@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When
QuorumReader(used for consistency levelsBounded StalenessandStrong) is not able to select a quorum because it only retrieved a response from a single Secondary. TheReadPrimaryAsynccall will fail because the replica set size is larger thanReadQuorum. Any retry there-after should include the Primary - so, that Primary and one Secondary can build quorum - otherwise as long as only one Secondary is actually reachable we can't serve the read operations even when 1 Secondary and 1 Primary should be able to build quorum.All SDK Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines