Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EventHubs tracing and metrics: catch up with OTel specification #38899

Merged
merged 21 commits into from
Sep 19, 2024

Conversation

lmolkova
Copy link
Member

@lmolkova lmolkova commented Feb 23, 2024

Description

  • Updates EventHubs to the latest otel semconv (yet to be released, so this PR will need to wait).
  • Refactors how tracing and metrics are done to minimize their effect on calling code and maximize testability.
  • Adds tons of non-mocking unit tests for tracing and metrics.

It addresses most of #37445 part for EH (all but feature flag) and significant portion of #38351

(PS: I think I finally found the right pattern to trace reactor publishers 😅)

@github-actions github-actions bot added Azure.Core azure-core Event Hubs OpenTelemetry OpenTelemetry instrumentation labels Feb 23, 2024
@azure-sdk
Copy link
Collaborator

azure-sdk commented Feb 23, 2024

API change check

API changes are not detected in this pull request.

@lmolkova
Copy link
Member Author

/azp run java - eventhubs - tests

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@lmolkova
Copy link
Member Author

/azp run java - eventhubs - tests

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@lmolkova lmolkova force-pushed the eh-catch-up-with-spec branch 2 times, most recently from b0bc1f7 to b8b348a Compare April 4, 2024 23:07
@lmolkova lmolkova marked this pull request as ready for review April 4, 2024 23:07
@lmolkova lmolkova force-pushed the eh-catch-up-with-spec branch from b8b348a to 39429b9 Compare April 19, 2024 23:43
@lmolkova lmolkova force-pushed the eh-catch-up-with-spec branch from 39429b9 to aa92807 Compare May 8, 2024 19:15
@lmolkova lmolkova force-pushed the eh-catch-up-with-spec branch from aa92807 to 20b5d25 Compare June 20, 2024 00:05
Copy link

Hi @lmolkova. Thank you for your interest in helping to improve the Azure SDK experience and for your contribution. We've noticed that there hasn't been recent engagement on this pull request. If this is still an active work stream, please let us know by pushing some changes or leaving a comment. Otherwise, we'll close this out in 7 days.

@github-actions github-actions bot added the no-recent-activity There has been no recent activity on this issue. label Aug 23, 2024
@lmolkova lmolkova removed the no-recent-activity There has been no recent activity on this issue. label Aug 29, 2024
@lmolkova
Copy link
Member Author

dear bot, please don't close it.

@lmolkova lmolkova force-pushed the eh-catch-up-with-spec branch from 6775987 to 762d7c4 Compare September 19, 2024 02:09
@lmolkova lmolkova enabled auto-merge (squash) September 19, 2024 02:09
@lmolkova lmolkova disabled auto-merge September 19, 2024 05:07
@lmolkova lmolkova merged commit f37c884 into Azure:main Sep 19, 2024
38 checks passed
@Azure Azure deleted a comment Oct 1, 2024
@Azure Azure deleted a comment Oct 1, 2024
@Azure Azure deleted a comment Oct 1, 2024
@Azure Azure deleted a comment Oct 7, 2024
mssfang pushed a commit to mssfang/azure-sdk-for-java that referenced this pull request Oct 21, 2024
…e#38899)

* Update EH to the latest otel spec and rework metrics

* generic operation duration and nits

* fix tests and update

* test: remove v2 stack

* tryme

* tryme

* up

* up

* up

* up

* remove global otel

* up

* up

* up

* up

* up

* up

* lint and stress test fixes

* Rebase and review comments

* Rebase and review comments

* nits
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Azure.Core azure-core Event Hubs OpenTelemetry OpenTelemetry instrumentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants