-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate java pipelines to 1es pipeline templates #39243
Conversation
- name: LINUXVMIMAGE | ||
value: azsdk-pool-mms-ubuntu-2004-1espt | ||
- name: LINUXNEXTVMIMAGE | ||
value: ubuntu-22.04 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
value: ubuntu-22.04 | |
value: azsdk-pool-mms-ubuntu-2204-1espt |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I realize on correcting you that I ALSO need to PR this to js/python
👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
AFAICT it LGTM.
I left a couple comments for clarity, but you've been hitting this hard over the last couple days and it shows.
I can't imagine we won't see fallout come Monday, but that's fine.
/azp run java - core - ci |
Azure Pipelines failed to run 1 pipeline(s). |
/check-enforcer override |
* Migrate java pipelines to 1es pipeline templates Co-authored-by: Scott Beddall (from Dev Box) <scbedd@microsoft.com> Co-authored-by: Alan Zimmer <48699787+alzimmermsft@users.noreply.github.com> * PR, main fixes * Disable spotbugs in 1es sdl * Set storage pool replace * Fix custom live test extends (cosmos, spring, communicatiion) * Fix linux next image value * Set sdl config on public * Add cspell ignore for matrix test config files --------- Co-authored-by: Scott Beddall (from Dev Box) <scbedd@microsoft.com> Co-authored-by: Alan Zimmer <48699787+alzimmermsft@users.noreply.github.com>
* Migrate java pipelines to 1es pipeline templates Co-authored-by: Scott Beddall (from Dev Box) <scbedd@microsoft.com> Co-authored-by: Alan Zimmer <48699787+alzimmermsft@users.noreply.github.com> * PR, main fixes * Disable spotbugs in 1es sdl * Set storage pool replace * Fix custom live test extends (cosmos, spring, communicatiion) * Fix linux next image value * Set sdl config on public * Add cspell ignore for matrix test config files --------- Co-authored-by: Scott Beddall (from Dev Box) <scbedd@microsoft.com> Co-authored-by: Alan Zimmer <48699787+alzimmermsft@users.noreply.github.com> (cherry picked from commit 9e789e6)
* Migrate java pipelines to 1es pipeline templates Co-authored-by: Scott Beddall (from Dev Box) <scbedd@microsoft.com> Co-authored-by: Alan Zimmer <48699787+alzimmermsft@users.noreply.github.com> * PR, main fixes * Disable spotbugs in 1es sdl * Set storage pool replace * Fix custom live test extends (cosmos, spring, communicatiion) * Fix linux next image value * Set sdl config on public * Add cspell ignore for matrix test config files --------- Co-authored-by: Scott Beddall (from Dev Box) <scbedd@microsoft.com> Co-authored-by: Alan Zimmer <48699787+alzimmermsft@users.noreply.github.com> (cherry picked from commit 9e789e6)
HIGHLY RECOMMEND VIEWING DIFF WITH HIDE WHITESPACE CHECKED
Updating main ci/test pipelines to extend from 1es pipeline templates.
This is a first draft (or rather 101st draft) with a few edits to be made but I wanted to get this out for review.
I still need to rebase a couple changes (mainly #39221), and consolidate some of the eng/common updates, as well potentially merge the sparse checkout init changes into eng/common as well.
Pipelines are passing (internal) or at least appear to have parity in template (ci/release/live), core, storage, cosmos, spring, resourcemanager, native, patch release, bom, and a couple others. Code quality reports, agg reports and partner release may come in another PR.
CC @scbedd @alzimmermsft @weshaggard