Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate java pipelines to 1es pipeline templates #39243

Merged
merged 8 commits into from
Mar 16, 2024
Merged

Conversation

benbp
Copy link
Member

@benbp benbp commented Mar 15, 2024

HIGHLY RECOMMEND VIEWING DIFF WITH HIDE WHITESPACE CHECKED

Updating main ci/test pipelines to extend from 1es pipeline templates.

This is a first draft (or rather 101st draft) with a few edits to be made but I wanted to get this out for review.

I still need to rebase a couple changes (mainly #39221), and consolidate some of the eng/common updates, as well potentially merge the sparse checkout init changes into eng/common as well.

Pipelines are passing (internal) or at least appear to have parity in template (ci/release/live), core, storage, cosmos, spring, resourcemanager, native, patch release, bom, and a couple others. Code quality reports, agg reports and partner release may come in another PR.

CC @scbedd @alzimmermsft @weshaggard

- name: LINUXVMIMAGE
value: azsdk-pool-mms-ubuntu-2004-1espt
- name: LINUXNEXTVMIMAGE
value: ubuntu-22.04
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
value: ubuntu-22.04
value: azsdk-pool-mms-ubuntu-2204-1espt

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I realize on correcting you that I ALSO need to PR this to js/python 👍

Copy link
Member

@scbedd scbedd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AFAICT it LGTM.

I left a couple comments for clarity, but you've been hitting this hard over the last couple days and it shows.

I can't imagine we won't see fallout come Monday, but that's fine.

@benbp
Copy link
Member Author

benbp commented Mar 15, 2024

/azp run java - core - ci

Copy link

Azure Pipelines failed to run 1 pipeline(s).

@benbp benbp added the Central-EngSys This issue is owned by the Engineering System team. label Mar 15, 2024
@benbp
Copy link
Member Author

benbp commented Mar 16, 2024

/check-enforcer override

@benbp benbp merged commit 9e789e6 into main Mar 16, 2024
298 of 314 checks passed
@benbp benbp deleted the 1es-template-conversion-pr branch March 16, 2024 00:56
drielenr pushed a commit that referenced this pull request Apr 2, 2024
* Migrate java pipelines to 1es pipeline templates

Co-authored-by: Scott Beddall (from Dev Box) <scbedd@microsoft.com>
Co-authored-by: Alan Zimmer <48699787+alzimmermsft@users.noreply.github.com>

* PR, main fixes

* Disable spotbugs in 1es sdl

* Set storage pool replace

* Fix custom live test extends (cosmos, spring, communicatiion)

* Fix linux next image value

* Set sdl config on public

* Add cspell ignore for matrix test config files

---------

Co-authored-by: Scott Beddall (from Dev Box) <scbedd@microsoft.com>
Co-authored-by: Alan Zimmer <48699787+alzimmermsft@users.noreply.github.com>
Netyyyy pushed a commit that referenced this pull request Jul 15, 2024
* Migrate java pipelines to 1es pipeline templates

Co-authored-by: Scott Beddall (from Dev Box) <scbedd@microsoft.com>
Co-authored-by: Alan Zimmer <48699787+alzimmermsft@users.noreply.github.com>

* PR, main fixes

* Disable spotbugs in 1es sdl

* Set storage pool replace

* Fix custom live test extends (cosmos, spring, communicatiion)

* Fix linux next image value

* Set sdl config on public

* Add cspell ignore for matrix test config files

---------

Co-authored-by: Scott Beddall (from Dev Box) <scbedd@microsoft.com>
Co-authored-by: Alan Zimmer <48699787+alzimmermsft@users.noreply.github.com>

(cherry picked from commit 9e789e6)
Netyyyy pushed a commit that referenced this pull request Jul 15, 2024
* Migrate java pipelines to 1es pipeline templates

Co-authored-by: Scott Beddall (from Dev Box) <scbedd@microsoft.com>
Co-authored-by: Alan Zimmer <48699787+alzimmermsft@users.noreply.github.com>

* PR, main fixes

* Disable spotbugs in 1es sdl

* Set storage pool replace

* Fix custom live test extends (cosmos, spring, communicatiion)

* Fix linux next image value

* Set sdl config on public

* Add cspell ignore for matrix test config files

---------

Co-authored-by: Scott Beddall (from Dev Box) <scbedd@microsoft.com>
Co-authored-by: Alan Zimmer <48699787+alzimmermsft@users.noreply.github.com>

(cherry picked from commit 9e789e6)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
App Configuration Azure.ApplicationModel.Configuration Azure.Core azure-core Azure.Identity azure-spring All azure-spring related issues Central-EngSys This issue is owned by the Engineering System team. Cognitive - Form Recognizer Cognitive - Text Analytics Communication - Phone Numbers Cosmos EngSys This issue is impacting the engineering system. Event Hubs KeyVault Service Bus Storage Storage Service (Queues, Blobs, Files) Tables
Projects
Archived in project
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants