-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Azure Remote Rendering tests by adding now missing dependencies and changed conversion error messages #39403
Fix Azure Remote Rendering tests by adding now missing dependencies and changed conversion error messages #39403
Conversation
/azp run java - remoterendering - tests |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run java - remoterendering - tests |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run java - remoterendering - tests |
Azure Pipelines successfully started running 1 pipeline(s). |
So, that change isn't great. The test fixes are absolutely fine, but the test framework fixes are kinda bad. Problem is, that the new HTTP client azure-core-http-jdk-httpclient doesn't work with Java 1.8. From the matrix config file it looks like it shouldn't be run in tandem, only with 1.17, but it somehow does anyway. So I disabled Java 1.8 tests for now and will contact the person that added the azure-core-http-jdk-httpclient tests to see if we can find a better solution. I would still go forward with this PR, as we are currently testing nothing and there is a risk of missing breaks in the releases for normal ARR (not the java SDK itself). |
<dependency> | ||
<groupId>com.azure</groupId> | ||
<artifactId>azure-core-http-jdk-httpclient</artifactId> | ||
<version>1.0.0-beta.11</version> <!-- {x-version-update;com.azure:azure-core-http-jdk-httpclient;dependency} --> | ||
</dependency> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To have the tests work properly with Java 8, you'll want to remove this dependency and leave what is added later on with the JDK 12+ profile
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<profiles>
<profile>
<id>java12plus</id>
<activation>
<jdk>[12,)</jdk>
</activation>
<dependencies>
<dependency>
<groupId>com.azure</groupId>
<artifactId>azure-core-http-jdk-httpclient</artifactId>
<version>1.0.0-beta.11</version> <!-- {x-version-update;com.azure:azure-core-http-jdk-httpclient;dependency} -->
<scope>test</scope>
</dependency>
</dependencies>
</profile>
</profiles>
<dependency> | ||
<groupId>com.azure</groupId> | ||
<artifactId>azure-core-http-vertx</artifactId> | ||
<version>1.0.0-beta.16</version> <!-- {x-version-update;com.azure:azure-core-http-vertx;dependency} --> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is missing test scope
Description
Please add an informative description that covers that changes made by the pull request and link all relevant issues.
If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
All SDK Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines