STG94 Authorization Error Detail

sdk/storage/azure-storage-file-share/assets.json

@@ -2,5 +2,5 @@
   "AssetsRepo": "Azure/azure-sdk-assets",
   "AssetsRepoPrefixPath": "java",
   "TagPrefix": "java/storage/azure-storage-file-share",
-  "Tag": "java/storage/azure-storage-file-share_011cc52a61"
+  "Tag": "java/storage/azure-storage-file-share_5a1b3f763c"
 }

sdk/storage/azure-storage-file-share/src/main/java/com/azure/storage/file/share/implementation/models/StorageError.java

@@ -18,6 +18,12 @@ public final class StorageError {
     @JsonProperty(value = "Message")
     private String message;
 
+    /*
+     * The AuthenticationErrorDetail property.
+     */
+    @JsonProperty(value = "AuthenticationErrorDetail")
+    private String authenticationErrorDetail;
+
     /** Creates an instance of StorageError class. */
     public StorageError() {}
 
@@ -40,4 +46,24 @@ public StorageError setMessage(String message) {
         this.message = message;
         return this;
     }
+
+    /**
+     * Get the authenticationErrorDetail property: The AuthenticationErrorDetail property.
+     *
+     * @return the authenticationErrorDetail value.
+     */
+    public String getAuthenticationErrorDetail() {
+        return this.authenticationErrorDetail;
+    }
+
+    /**
+     * Set the authenticationErrorDetail property: The AuthenticationErrorDetail property.
+     *
+     * @param authenticationErrorDetail the authenticationErrorDetail value to set.
+     * @return the StorageError object itself.
+     */
+    public StorageError setAuthenticationErrorDetail(String authenticationErrorDetail) {
+        this.authenticationErrorDetail = authenticationErrorDetail;
+        return this;
+    }
 }

sdk/storage/azure-storage-file-share/src/test/java/com/azure/storage/file/share/ShareApiTests.java

@@ -154,6 +154,20 @@ public void createShare() {
             201);
     }
 
+    @RequiredServiceVersion(clazz = ShareServiceVersion.class, min = "2024-08-04")
+    @Test
+    public void createShareSasError() {
+        ShareServiceClient unauthorizedServiceClient = fileServiceBuilderHelper()
+            .sasToken("sig=dummyToken")
+            .buildClient();
+
+        ShareClient share = unauthorizedServiceClient.getShareClient(generateShareName());
+
+        ShareStorageException e = assertThrows(ShareStorageException.class, share::create);
+        assertEquals(ShareErrorCode.AUTHENTICATION_FAILED, e.getErrorCode());
+        assertTrue(e.getServiceMessage().contains("AuthenticationErrorDetail"));
+    }
+
     @RequiredServiceVersion(clazz = ShareServiceVersion.class, min = "2019-12-12")
     @ParameterizedTest
     @MethodSource("createShareWithArgsSupplier")

sdk/storage/azure-storage-file-share/src/test/java/com/azure/storage/file/share/ShareAsyncApiTests.java

@@ -6,6 +6,7 @@
 import com.azure.core.http.rest.Response;
 import com.azure.storage.common.StorageSharedKeyCredential;
 import com.azure.storage.common.test.shared.extensions.PlaybackOnly;
+import com.azure.storage.common.test.shared.extensions.RequiredServiceVersion;
 import com.azure.storage.file.share.implementation.util.ModelHelper;
 import com.azure.storage.file.share.models.NtfsFileAttributes;
 import com.azure.storage.file.share.models.ShareAudience;
@@ -88,6 +89,23 @@ public void createShare() {
             .assertNext(it -> FileShareTestHelper.assertResponseStatusCode(it, 201)).verifyComplete();
     }
 
+    @RequiredServiceVersion(clazz = ShareServiceVersion.class, min = "2024-08-04")
+    @Test
+    public void createShareSasError() {
+        ShareServiceAsyncClient unauthorizedServiceClient = fileServiceBuilderHelper()
+            .sasToken("sig=dummyToken")
+            .buildAsyncClient();
+
+        ShareAsyncClient share = unauthorizedServiceClient.getShareAsyncClient(generateShareName());
+
+        StepVerifier.create(share.create())
+            .verifyErrorSatisfies(r -> {
+                ShareStorageException e = assertInstanceOf(ShareStorageException.class, r);
+                assertEquals(ShareErrorCode.AUTHENTICATION_FAILED, e.getErrorCode());
+                assertTrue(e.getServiceMessage().contains("AuthenticationErrorDetail"));
+            });
+    }
+
     @ParameterizedTest
     @MethodSource("createShareWithArgsSupplier")
     public void createShareWithArgs(Map<String, String> metadata, Integer quota) {

sdk/storage/azure-storage-file-share/swagger/README.md

@@ -16,7 +16,7 @@ autorest
 ### Code generation settings
 ``` yaml
 use: '@autorest/java@4.1.16'
-input-file: https://raw.githubusercontent.com/Azure/azure-rest-api-specs/3f9cca0301ffbb8856826d196c567d821ae190d7/specification/storage/data-plane/Microsoft.FileStorage/preview/2024-05-04/file.json
+input-file: https://raw.githubusercontent.com/Azure/azure-rest-api-specs/12e0ceead6d4611abdd617d2bbc5c9068e4c772a/specification/storage/data-plane/Microsoft.FileStorage/stable/2024-08-04/file.json
 java: true
 output-folder: ../
 namespace: com.azure.storage.file.share