-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Regenerate Job Router with stream-style serialization and remove many Internal models #40397
Regenerate Job Router with stream-style serialization and remove many Internal models #40397
Conversation
API change check APIView has identified API level changes in this PR and created following API reviews. |
@williamzhao87 could you take a look at this PR. It's onboarding Job Router to azure-json and using code customizations to remove a lot of the mapping logic from custom to generated types but having the generated types handle the same as the custom types. |
@alzimmermsft Thanks for submitting the PR with these extensive changes! Everything here looks good to me. |
|
||
/** | ||
* Response payload from cancelling a job. | ||
*/ | ||
@Immutable | ||
public final class CancelJobResultInternal { | ||
public final class CancelJobResultInternal implements JsonSerializable<CancelJobResultInternal> { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just curious, it's only the empty internal classes that cannot be removed, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I really never figured out what to do with this class and the similar Internal
classes as they're defined in the TypeSpec without any properties but are used in service methods that are hidden from the public API, so I left them. These can be followed up on if they should be removed.
Description
Regenerates
azure-communication-jobrouter
with stream-style serialization enabled. Additionally, adds numerous code customizations so that the*Internal
model mapping pattern can be reduced greatly, lowering maintenance costs and possible bugs when mapping handwritten models to generated models.There will need to be a corresponding change in
azure-rest-api-specs
based on what I changed manually inmodels.tsp
andtspconfig.yml
while creating this PR. I will open that PR once this has approval.All SDK Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines