Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate azure-ai-translation-document to azure-json #42504

Merged

Conversation

alzimmermsft
Copy link
Member

Description

Migrates azure-ai-translation-document to azure-json serialization, rather than Jackson serialization. TypeSpec SHA links to an unmerged PR in azure-rest-api-specs (Azure/azure-rest-api-specs#31132) that should be merged (and the SHA updated to the merge SHA) before this PR can merge.

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@azure-sdk
Copy link
Collaborator

API change check

APIView has identified API level changes in this PR and created following API reviews.

com.azure:azure-ai-translation-document

@alzimmermsft alzimmermsft merged commit 44f65d4 into Azure:main Oct 23, 2024
19 checks passed
@alzimmermsft alzimmermsft deleted the AzTranslation_MigrateToAzureJson branch October 23, 2024 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants