Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update azure-core-* packages to 1.0.0-preview.3 #4344

Merged
merged 4 commits into from
Jul 9, 2019
Merged

Update azure-core-* packages to 1.0.0-preview.3 #4344

merged 4 commits into from
Jul 9, 2019

Conversation

conniey
Copy link
Member

@conniey conniey commented Jul 9, 2019 •
edited
Loading

  • Update azure-core-* packages to 1.0.0-preview.3
  • Update azure-core-* dependencies in some Track 2 libraries because they use the new annotations or the ClientLogger updates
    • App Configuration
    • Key Vault
    • Event Hubs

@conniey conniey self-assigned this Jul 9, 2019
JonathanGiles
JonathanGiles approved these changes Jul 9, 2019
View reviewed changes
Copy link
Member

@JonathanGiles JonathanGiles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Just note Key Vault is about to move into /sdk, so this might need updating soon.

@conniey
Copy link
Member Author

conniey commented Jul 9, 2019 •
edited
Loading

Looks good. Just note Key Vault is about to move into /sdk, so this might need updating soon.

@JonathanGiles I'm hoping that this build finishes and is successful so I can leave the merging to @mitchdenny. 😈

@conniey conniey mentioned this pull request Jul 9, 2019
Merged
@conniey conniey merged commit 6d7099b into Azure:master Jul 9, 2019
@conniey conniey deleted the revisions branch July 9, 2019 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JonathanGiles JonathanGiles JonathanGiles approved these changes

@weshaggard weshaggard weshaggard approved these changes

@mitchdenny mitchdenny Awaiting requested review from mitchdenny

Assignees

@conniey conniey

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@conniey @JonathanGiles @weshaggard