Introduce useRestProxy Flag to Enable RestProxy Functionality
#43753
+56
−39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samvaity
commented
Jan 10, 2025
| final SwaggerInterfaceParser interfaceParser = SwaggerInterfaceParser.getInstance(swaggerInterface); | ||
| final RestProxy restProxy | ||
| = new RestProxy(httpPipeline, interfaceParser, new JsonSerializer(), new XmlSerializer()); | ||
| public static <A> A create(Class<A> swaggerInterface, HttpPipeline httpPipeline, boolean useRestProxy) { |
There was a problem hiding this comment.
@srnagar I added it to the public API so that we can have the ServiceClientImpl generation to on/off the flag but that would make it a part of generation utility too, Thoughts?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces a
useRestProxyflag to toggle the use ofRestProxy.createfunctionality. This flag ensures that when compile-time code generation is used (i.e.,useRestProxyis set to false), we do not inadvertently use theRestProxycode path.Does this capture what you intended?
All SDK Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines