-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate UsernamePasswordCredential #44381
Deprecate UsernamePasswordCredential #44381
Conversation
Due to changes around how MFA is required in Azure tenants, UsernamePasswordCredential is no longer recommended.
API change check API changes are not detected in this pull request. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey, some additional changes that were made in Python could also be made here:
- Update README.md to mark the credential Deprecated in the credential list and a note in the
Environment variables
section regarding username + password authentication. - A note in the EnvironmentCredential docstring under the username + password portion about this mode of authentication being deprecated.
sdk/identity/azure-identity/src/main/java/com/azure/identity/UsernamePasswordCredential.java
Outdated
Show resolved
Hide resolved
...ntity/azure-identity/src/main/java/com/azure/identity/UsernamePasswordCredentialBuilder.java
Outdated
Show resolved
Hide resolved
…sernamePasswordCredential.java Co-authored-by: Scott Addie <10702007+scottaddie@users.noreply.github.com>
…sernamePasswordCredentialBuilder.java Co-authored-by: Scott Addie <10702007+scottaddie@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think just missing one more deprecated disclaimer in the Environment variables ### Username and password
section of the readme, but otherwise LGTM.
@saragluna ptal for the changes to spring files. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM for the Spring changes.
Closes https://github.com/Azure/azure-sdk-for-java-pr/issues/1432
Due to changes around how MFA is required in Azure tenants, UsernamePasswordCredential is no longer recommended.