Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate UsernamePasswordCredential #44381

Merged
merged 15 commits into from
Mar 8, 2025

Conversation

billwert
Copy link
Contributor

@billwert billwert commented Feb 25, 2025

Closes https://github.com/Azure/azure-sdk-for-java-pr/issues/1432

Due to changes around how MFA is required in Azure tenants, UsernamePasswordCredential is no longer recommended.

Due to changes around how MFA is required in Azure tenants, UsernamePasswordCredential is no longer recommended.
@azure-sdk
Copy link
Collaborator

azure-sdk commented Feb 25, 2025

API change check

API changes are not detected in this pull request.

Copy link
Member

@pvaneck pvaneck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, some additional changes that were made in Python could also be made here:

  • Update README.md to mark the credential Deprecated in the credential list and a note in the Environment variables section regarding username + password authentication.
  • A note in the EnvironmentCredential docstring under the username + password portion about this mode of authentication being deprecated.

billwert and others added 3 commits February 25, 2025 13:13
…sernamePasswordCredential.java

Co-authored-by: Scott Addie <10702007+scottaddie@users.noreply.github.com>
…sernamePasswordCredentialBuilder.java

Co-authored-by: Scott Addie <10702007+scottaddie@users.noreply.github.com>
Copy link
Member

@pvaneck pvaneck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think just missing one more deprecated disclaimer in the Environment variables ### Username and password section of the readme, but otherwise LGTM.

@billwert
Copy link
Contributor Author

@saragluna ptal for the changes to spring files.

Copy link
Member

@saragluna saragluna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for the Spring changes.

@billwert billwert merged commit 7355472 into Azure:main Mar 8, 2025
68 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

5 participants