Generating Java SDK for 2024-12-09preview API version #44949
Conversation
amruthashree18
requested review from
joshfree,
srnagar,
anuchandy,
conniey,
lmolkova and
JonathanGiles
as code owners
|
API change check APIView has identified API level changes in this PR and created following API reviews. |
amruthashree18
requested review from
weidongxu-microsoft,
haolingdong-msft,
XiaofeiCao and
ArthurMa1978
as code owners
| @@ -185,7 +185,7 @@ public LedgersClient getLedgers() { | |||
| this.defaultPollInterval = defaultPollInterval; | |||
| this.subscriptionId = subscriptionId; | |||
| this.endpoint = endpoint; | |||
| this.apiVersion = "2022-05-13"; | |||
| this.apiVersion = "2024-12-09"; | |||
There was a problem hiding this comment.
Why change to mgmt lib?
Change here would require a regen too. It is unlikely you have api-version change but no API change.
...er/src/main/java/com/azure/security/confidentialledger/ConfidentialLedgerServiceVersion.java
Show resolved
Hide resolved
| @Generated | ||
| public ConfidentialLedgerClientBuilder ledgerEndpoint(String ledgerEndpoint) { | ||
| this.ledgerEndpoint = ledgerEndpoint; | ||
| @Override | ||
| public ConfidentialLedgerClientBuilder endpoint(String endpoint) { | ||
| this.endpoint = endpoint; | ||
| return this; | ||
| } |
There was a problem hiding this comment.
After the fix to ServiceVersion, this seems the only breaking changes in PR.
The cause is from your Swagger, previously it is {ledgerEndpoint} in stable, and now it is {endpoint} in preview.
Please discussion this with SDK arch.
There was a problem hiding this comment.
This is already reviewed and approved earlier when we generated SDK on .net
There was a problem hiding this comment.
We should not have a breaking change here. We should rename the method to ledgerEndpoint to maintain backward compatibility.
…s://github.com/amruthashree18/azure-sdk-for-java into amruthashree18/generateJavaSDK-20241209Preview
There was a problem hiding this comment.
there is no real change in this file, please remove the file from PR
Description
Please add an informative description that covers that changes made by the pull request and link all relevant issues.
If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
All SDK Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines