fix: upgrades jackson to 2.18.4.1 to fix android build failures #45662
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
baywet
requested review from
a team,
JonathanGiles,
Netyyyy,
abhipsaMisra,
alzimmermsft,
andyk-ms,
brycewang-microsoft,
digimaun,
g2vinay,
jairmyree,
moarychan,
mrm9084,
rujche,
samvaity,
saragluna,
srnagar,
timtay-microsoft and
vcolin7
as code owners
baywet
requested review from
NickKouds,
anuchandy,
dpwatrous,
kirankumarkolli,
lmolkova,
skapur12 and
wiboris
as code owners
github-actions
bot
added
Azure SDK Tools
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates all Jackson dependencies to version 2.18.4.1 to resolve Android build failures.
- Bumps Jackson core, annotations, databind, datatype, dataformat, and module versions across SDK modules
- Updates bannedDependencies rules to match the new Jackson version
- Syncs
external_dependencies.txtand BOM generator entries for Jackson modules
Reviewed Changes
Copilot reviewed 26 out of 26 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| sdk/serialization/azure-json/pom.xml | Bump jackson-core to 2.18.4.1 |
| sdk/parents/clientcore-parent/pom.xml | Bump jackson-databind to 2.18.4.1 |
| sdk/parents/azure-client-sdk-parent/pom.xml | Bump jackson-databind to 2.18.4.1 |
| sdk/parents/azure-client-sdk-parent-v2/pom.xml | Bump jackson-databind to 2.18.4.1 |
| sdk/modelsrepository/azure-iot-modelsrepository/pom.xml | Bump jackson-dataformat-xml, core, databind to 2.18.4.1 and update ban rules |
| sdk/keyvault/azure-security-test-keyvault-jca/pom.xml | Bump jackson-databind to 2.18.4.1 (test scope) |
| sdk/cosmos/azure-cosmos/pom.xml | Bump jackson-module-afterburner, blackbird to 2.18.4.1 and update ban rules |
| sdk/cosmos/azure-cosmos-tests/pom.xml | Bump jackson-module-afterburner, blackbird to 2.18.4.1 |
| sdk/cosmos/azure-cosmos-spark_3_2-12/pom.xml | Bump jackson-module-afterburner to 2.18.4.1 |
| sdk/cosmos/azure-cosmos-spark_3-5_2-12/pom.xml | Bump jackson-databind, datatype-jsr310, afterburner, scala to 2.18.4.1 |
| sdk/cosmos/azure-cosmos-spark_3-4_2-12/pom.xml | Bump jackson-databind, scala to 2.18.4.1 |
| sdk/cosmos/azure-cosmos-spark_3-3_2-12/pom.xml | Bump jackson-databind, scala to 2.18.4.1 |
| sdk/cosmos/azure-cosmos-spark-account-data-resolver-sample/pom.xml | Bump banned Jackson includes to 2.18.4.1 |
| sdk/core/azure-core/pom.xml | Bump jackson-annotations, core, databind, datatype, dataformat to 2.18.4.1 and update ban rules |
| sdk/core/azure-core-version-tests/pom.xml | Bump Jackson dependencies to 2.18.4.1 and update ban rules |
| sdk/core/azure-core-serializer-json-jackson/pom.xml | Bump Jackson dependencies to 2.18.4.1 and update ban rules |
| sdk/batch/microsoft-azure-batch/pom.xml | Bump jackson-core to 2.18.4.1 (test scope) |
| eng/versioning/external_dependencies.txt | Update Jackson entries to 2.18.4.1 |
| eng/code-quality-reports/pom.xml | Bump jackson-databind to 2.18.4.1 |
| eng/bomgenerator/pom.xml | Bump jackson-dataformat-xml to 2.18.4.1 |
Comments suppressed due to low confidence (2)
sdk/cosmos/azure-cosmos-spark-account-data-resolver-sample/pom.xml:292
- There is a bannedDependencies entry for jackson-databind at version 2.15.2 in addition to 2.18.4.1—this may be unintended duplication and could conflict. Consider removing or consolidating the 2.15.2 entry if it's no longer needed.
<include>com.fasterxml.jackson.core:jackson-databind:[2.15.2]</include> <!-- {x-include-update;cosmos_com.fasterxml.jackson.core:jackson-databind;external_dependency} -->
sdk/cosmos/azure-cosmos-spark-account-data-resolver-sample/pom.xml:293
- Similar to the previous entry, there's a banned Scala module at version 2.15.2 alongside 2.18.4.1. Verify whether the older ban is still required or should be removed.
<include>com.fasterxml.jackson.module:jackson-module-scala_2.12:[2.15.2]</include> <!-- {x-include-update;cosmos_com.fasterxml.jackson.module:jackson-module-scala_2.12;external_dependency} -->
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
Contributor
API Change CheckAPIView identified API level changes in this PR and created the following API reviews |
baywet
commented
Jun 11, 2025
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
alzimmermsft
approved these changes
Jun 12, 2025
This was referenced Jun 16, 2025
github-project-automation
bot
moved this from Untriaged
to Done
in Azure SDK for Key Vault
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #45634