Skip to content

Conversation

@XiaofeiCao
Copy link
Contributor

@XiaofeiCao XiaofeiCao commented Jul 7, 2025

Description

Fix datadog migration checkstyle: https://dev.azure.com/azure-sdk/public/_build/results?buildId=5044267&view=logs&j=83516c17-6666-5250-abde-63983ce72a49&t=00be4b52-4a63-5865-8e02-c61723ad0692&l=751

Due to codegen update, output-only models are annotated with @Immutable now.

Please add an informative description that covers that changes made by the pull request and link all relevant issues.

If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@XiaofeiCao XiaofeiCao marked this pull request as ready for review July 7, 2025 08:45
Copilot AI review requested due to automatic review settings July 7, 2025 08:45
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds a Checkstyle suppression for the DatadogSetPasswordLinkInner model, which is now annotated @Immutable but has a generated setter method that triggers the ImmutableClassCheck.

  • Added suppression entry in checkstyle-suppressions.xml for the Datadog model.
  • Included a descriptive comment explaining the suppression.
Comments suppressed due to low confidence (1)

eng/code-quality-reports/src/main/resources/checkstyle/checkstyle-suppressions.xml:118

  • [nitpick] Consider clarifying this comment to explain why the suppression is needed, for example: // Suppress ImmutableClassCheck for DatadogSetPasswordLinkInner (output-only model with a generated setter).
  <!-- Suppress the @Immutable class with a property named "setPasswordLink"  -->

@XiaofeiCao XiaofeiCao merged commit 8e7c3b0 into Azure:main Jul 8, 2025
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants