Skip to content

Sync eng/common directory with azure-sdk-tools for PR 13307 #47548

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
weshaggard merged 4 commits into from
Dec 11, 2025
Merged

Sync eng/common directory with azure-sdk-tools for PR 13307 #47548

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
688624d
Fix npm URL replacement logic to handle versioned and non-versioned URLs
Copilot Dec 10, 2025
d2a9cb3
Simplify regex pattern as suggested by weshaggard
Copilot Dec 11, 2025
2175b9d
Fix regex to handle query params and fragments, add edge case tests
Copilot Dec 11, 2025
276e98b
Merge branch 'main' into sync-eng/common-copilot/update-npm-url-repla…
weshaggard Dec 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 18 additions & 1 deletion eng/common/scripts/Verify-Links.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,7 +163,24 @@ function ProcessCratesIoLink([System.Uri]$linkUri, $path) {
function ProcessNpmLink([System.Uri]$linkUri) {
# npmjs.com started using Cloudflare which returns 403 and we need to instead check the registry api for existence checks
# https://github.com/orgs/community/discussions/174098#discussioncomment-14461226
$apiUrl = $linkUri.ToString() -replace '^https?://(?:www\.)?npmjs\.com/package/(.*)/v', 'https://registry.npmjs.org/$1'

# Handle versioned URLs: https://www.npmjs.com/package/@azure/ai-agents/v/1.1.0 -> https://registry.npmjs.org/@azure/ai-agents/1.1.0
# Handle non-versioned URLs: https://www.npmjs.com/package/@azure/ai-agents -> https://registry.npmjs.org/@azure/ai-agents
# The regex captures the package name (which may contain a slash for scoped packages) and optionally the version.
# Query parameters and URL fragments are excluded from the transformation.
$urlString = $linkUri.ToString()
if ($urlString -match '^https?://(?:www\.)?npmjs\.com/package/([^?#]+)/v/([^?#]+)') {
# Versioned URL: remove the /v/ segment but keep the version
$apiUrl = "https://registry.npmjs.org/$($matches[1])/$($matches[2])"
}
elseif ($urlString -match '^https?://(?:www\.)?npmjs\.com/package/([^?#]+)') {
# Non-versioned URL: just replace the domain
$apiUrl = "https://registry.npmjs.org/$($matches[1])"
}
else {
# Fallback: use the original URL if it doesn't match expected patterns
$apiUrl = $urlString
}

return ProcessStandardLink ([System.Uri]$apiUrl)
}
Expand Down
Loading