-
Notifications
You must be signed in to change notification settings - Fork 2.2k
Fix Include stack trace in token error logs #47974
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
59 changes: 59 additions & 0 deletions
59
.../azure-identity/src/test/java/com/azure/identity/implementation/util/LoggingUtilTest.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,59 @@ | ||
| // Copyright (c) Microsoft Corporation. All rights reserved. | ||
| // Licensed under the MIT License. | ||
|
|
||
| package com.azure.identity.implementation.util; | ||
|
|
||
| import com.azure.core.credential.TokenRequestContext; | ||
| import com.azure.core.exception.ClientAuthenticationException; | ||
| import com.azure.core.util.Configuration; | ||
| import com.azure.core.util.logging.ClientLogger; | ||
| import com.azure.identity.implementation.IdentityClientOptions; | ||
| import org.junit.jupiter.api.Test; | ||
|
|
||
| import static org.junit.jupiter.api.Assertions.assertDoesNotThrow; | ||
|
|
||
| public class LoggingUtilTest { | ||
|
|
||
| private static final ClientLogger LOGGER = new ClientLogger(LoggingUtilTest.class); | ||
|
|
||
| @Test | ||
| public void testLogTokenErrorWithInnerException() { | ||
| // Create a nested exception to simulate the "see inner exception" scenario | ||
| Exception innerException = new RuntimeException("Inner exception details"); | ||
| ClientAuthenticationException outerException = new ClientAuthenticationException( | ||
| "Managed Identity authentication failed, see inner exception for more information.", null, innerException); | ||
|
|
||
| // Create a token request context | ||
| TokenRequestContext context = new TokenRequestContext().addScopes("https://management.azure.com/.default"); | ||
|
|
||
| // Create identity client options | ||
| IdentityClientOptions options = new IdentityClientOptions(); | ||
|
|
||
| // Verify that calling logTokenError doesn't throw an exception | ||
| // and that it properly handles the nested exception | ||
| assertDoesNotThrow(() -> LoggingUtil.logTokenError(LOGGER, options, context, outerException)); | ||
| } | ||
g2vinay marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
|
||
| @Test | ||
| public void testLogTokenErrorWithNullException() { | ||
| // Test that the method handles null exceptions gracefully | ||
| TokenRequestContext context = new TokenRequestContext().addScopes("https://management.azure.com/.default"); | ||
| IdentityClientOptions options = new IdentityClientOptions(); | ||
|
|
||
| assertDoesNotThrow(() -> LoggingUtil.logTokenError(LOGGER, options, context, null)); | ||
| } | ||
|
|
||
| @Test | ||
| public void testLogTokenSuccess() { | ||
| TokenRequestContext context = new TokenRequestContext().addScopes("https://management.azure.com/.default"); | ||
|
|
||
| assertDoesNotThrow(() -> LoggingUtil.logTokenSuccess(LOGGER, context)); | ||
| } | ||
|
|
||
| @Test | ||
| public void testLogAvailableEnvironmentVariables() { | ||
| Configuration configuration = Configuration.getGlobalConfiguration(); | ||
|
|
||
| assertDoesNotThrow(() -> LoggingUtil.logAvailableEnvironmentVariables(LOGGER, configuration)); | ||
| } | ||
| } | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.