Seeing if we can speed up spotbugs #4988
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…king the JVM for each module
|
/azp run java - core |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
This shaves about 25 seconds off of the Analyze job, so I think it is worth merging. |
mitchdenny
approved these changes
Aug 14, 2019
srnagar
reviewed
Aug 14, 2019
pom.client.xml
Outdated
| @@ -164,12 +164,13 @@ | |||
| </dependency> | |||
| </dependencies> | |||
| <configuration> | |||
| <effort>Max</effort> | |||
| <effort>min</effort> | |||
There was a problem hiding this comment.
Maybe we should run nightly builds with max or more and publish the results here
Min does very little and may not catch some issues.
https://spotbugs.readthedocs.io/en/stable/effort.html
There was a problem hiding this comment.
My expectation is even at min we should get everything we want.
There was a problem hiding this comment.
But I should add, there was almost no difference between min and max on my machine. The only win was from not forking the JVM for each module, so I am also happy to return this to max.
|
/azp run java - core |
|
Azure Pipelines successfully started running 1 pipeline(s). |
… the JVM for each spotbugs run.
pull bot
pushed a commit
to test-repo-tih/azure-sdk-for-java
that referenced
this pull request
Aug 14, 2019
* Seeing if we can speed up spotbugs by not forking the JVM for each module
pull bot
pushed a commit
to test-repo-billy/azure-sdk-for-java
that referenced
this pull request
Aug 14, 2019
* Seeing if we can speed up spotbugs by not forking the JVM for each module
pull bot
referenced
this pull request
in AzureSDKAutomation/azure-sdk-for-java
Aug 14, 2019
* Seeing if we can speed up spotbugs by not forking the JVM for each module
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
by lowering the effort and not forking the JVM for each module.
Fixes #4974