Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change last_modified and locked JsonProperty READ_ONLY #5537

Closed
wants to merge 26 commits into from
Closed

Change last_modified and locked JsonProperty READ_ONLY #5537

wants to merge 26 commits into from

Conversation

mssfang
Copy link
Member

@mssfang mssfang commented Sep 25, 2019

Change last_modified and locked JsonProperty READ_ONLY

mssfang added 26 commits July 11, 2019 11:40
@mssfang
remove java code isImple check but move to suppression and add only c…
4cac1b9 
…heck for public class for external Dependency check
@mssfang
resolve conflict
9dbeae5
@mssfang
Merge branch 'master' of https://github.com/Azure/azure-sdk-for-java
b52c5ab
@mssfang
Merge branch 'master' of https://github.com/Azure/azure-sdk-for-java
cdf50a0
@mssfang
Merge branch 'master' of https://github.com/Azure/azure-sdk-for-java
a41ffdc
@mssfang
Merge branch 'master' of https://github.com/Azure/azure-sdk-for-java
e7ea7f2
@mssfang
Merge branch 'master' of https://github.com/Azure/azure-sdk-for-java
9f7c156
@mssfang
Merge branch 'master' of https://github.com/Azure/azure-sdk-for-java
c3c3571
@mssfang
Merge branch 'master' of https://github.com/Azure/azure-sdk-for-java
304bc10
@mssfang
Merge branch 'master' of https://github.com/Azure/azure-sdk-for-java
a02d054
@mssfang
Merge branch 'master' of https://github.com/Azure/azure-sdk-for-java
d021dd7
@mssfang
Merge branch 'master' of https://github.com/Azure/azure-sdk-for-java
a9e3f76
@mssfang
Merge branch 'master' of https://github.com/Azure/azure-sdk-for-java
f407118
@mssfang
Merge branch 'master' of https://github.com/Azure/azure-sdk-for-java
c655db2
@mssfang
Merge branch 'master' of https://github.com/Azure/azure-sdk-for-java
a478811
@mssfang
Merge branch 'master' of https://github.com/Azure/azure-sdk-for-java
262e7fa
@mssfang
Merge branch 'master' of https://github.com/Azure/azure-sdk-for-java
4520fd0
@mssfang
Merge branch 'master' of https://github.com/Azure/azure-sdk-for-java
2525fd5
@mssfang
Merge branch 'master' of https://github.com/Azure/azure-sdk-for-java
2ae4f47
@mssfang
Merge branch 'master' of https://github.com/Azure/azure-sdk-for-java
aa60178
@mssfang
Merge branch 'master' of https://github.com/Azure/azure-sdk-for-java
e5b8626
@mssfang
Merge branch 'master' of https://github.com/Azure/azure-sdk-for-java
79b93dd
@mssfang
Merge branch 'master' of https://github.com/Azure/azure-sdk-for-java
31b6c5b
@mssfang
Merge branch 'master' of https://github.com/Azure/azure-sdk-for-java
3b199a0
@mssfang
Merge branch 'master' of https://github.com/Azure/azure-sdk-for-java …
50bc92b 
…into ReadOnly
@mssfang
Make JsonProperty last_modified and locked READ_ONLY
8d95a5b
@mssfang mssfang added Client This issue points to a problem in the data-plane of the library. App Configuration Azure.ApplicationModel.Configuration labels Sep 25, 2019
@mssfang mssfang requested a review from sima-zhu as a code owner September 25, 2019 20:55
@mssfang mssfang self-assigned this Sep 25, 2019
@alzimmermsft
Copy link
Member

Why are we changing the JSON serialization to readonly? We only needed to remove the setter method for these properties and that looks to be done already.

@mssfang
Copy link
Member Author

mssfang commented Sep 25, 2019 •
edited
Loading

Ahh. Misunderstood it. Closing this PR

@mssfang mssfang closed this Sep 25, 2019
@mssfang mssfang deleted the ReadOnly branch September 25, 2019 23:24
azure-sdk pushed a commit that referenced this pull request Mar 16, 2023
@mikeharder @azure-sdk
Revert "[check-spelling] Temporarily pin Node 18 to 18.13.0 (#5537)"
9331657 
This reverts commit 8a02e02adfc0d213509fce2764132afa74bd4ba4.
azure-sdk added a commit that referenced this pull request Mar 17, 2023
@azure-sdk @mikeharder
Revert "[check-spelling] Temporarily pin Node 18 to 18.13.0 (#5537)" (#…
d064223 
…34069)

This reverts commit 8a02e02adfc0d213509fce2764132afa74bd4ba4.

Co-authored-by: Mike Harder <mharder@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@conniey conniey Awaiting requested review from conniey

@alzimmermsft alzimmermsft Awaiting requested review from alzimmermsft

@sima-zhu sima-zhu Awaiting requested review from sima-zhu

Assignees

@mssfang mssfang

Labels
App Configuration Azure.ApplicationModel.Configuration Client This issue points to a problem in the data-plane of the library.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mssfang @alzimmermsft