[Key Vault Certificates] Happy path to avoid unstable live tests (#9879)

* [Key Vault Certificates] Happy path to avoid variable behavior in live tests * forgot these .only * added timeout on the package.json somewhere I missed before
Azure · Jul 6, 2020 · 0caf060 · 0caf060
1 parent 95d62b4
commit 0caf060
Show file tree

Hide file tree

Showing 30 changed files with 18,560 additions and 7,718 deletions.
diff --git a/sdk/keyvault/keyvault-certificates/package.json b/sdk/keyvault/keyvault-certificates/package.json
@@ -66,7 +66,7 @@
     "test:node": "npm run clean && npm run build:test && npm run unit-test:node",
     "test": "npm run clean && npm run build:test && npm run unit-test",
     "unit-test:browser": "karma start --single-run",
-    "unit-test:node": "mocha --require source-map-support/register --reporter ../../../common/tools/mocha-multi-reporter.js --no-timeouts --full-trace dist-test/index.node.js",
+    "unit-test:node": "mocha --require source-map-support/register --reporter ../../../common/tools/mocha-multi-reporter.js --timeout 180000 --full-trace dist-test/index.node.js",
     "unit-test:node:no-timeout": "mocha --require source-map-support/register --reporter ../../../common/tools/mocha-multi-reporter.js --no-timeouts --full-trace dist-test/index.node.js",
     "unit-test": "npm run unit-test:node && npm run unit-test:browser"
   },

diff --git a/...rtificates_client__list_certificates_in_various_ways/recording_can_list_certificates.json b/...rtificates_client__list_certificates_in_various_ways/recording_can_list_certificates.json
diff --git a/...es_client__list_certificates_in_various_ways/recording_can_list_certificates_by_page.json b/...es_client__list_certificates_in_various_ways/recording_can_list_certificates_by_page.json
diff --git a/...es_client__list_certificates_in_various_ways/recording_can_list_deleted_certificates.json b/...es_client__list_certificates_in_various_ways/recording_can_list_deleted_certificates.json
diff --git a/...t__list_certificates_in_various_ways/recording_can_list_deleted_certificates_by_page.json b/...t__list_certificates_in_various_ways/recording_can_list_deleted_certificates_by_page.json
diff --git a/...cates_client__list_certificates_in_various_ways/recording_can_purge_all_certificates.json b/...cates_client__list_certificates_in_various_ways/recording_can_purge_all_certificates.json
diff --git a/...browsers/certificates_client__lro__delete/recording_can_resume_from_a_stopped_poller.json b/...browsers/certificates_client__lro__delete/recording_can_resume_from_a_stopped_poller.json
diff --git a/...s/certificates_client__lro__delete/recording_can_wait_until_a_certificate_is_deleted.json b/...s/certificates_client__lro__delete/recording_can_wait_until_a_certificate_is_deleted.json
diff --git a/...ecoverdelete/recording_can_recover_a_deleted_certificate_with_requestoptions_timeout.json b/...ecoverdelete/recording_can_recover_a_deleted_certificate_with_requestoptions_timeout.json
diff --git a/...s/certificates_client__lro__recoverdelete/recording_can_resume_from_a_stopped_poller.json b/...s/certificates_client__lro__recoverdelete/recording_can_resume_from_a_stopped_poller.json
diff --git a/...cates_client__lro__recoverdelete/recording_can_wait_until_a_certificate_is_recovered.json b/...cates_client__lro__recoverdelete/recording_can_wait_until_a_certificate_is_recovered.json
diff --git a/...restore_certificates_and_recover_backups/recording_can_recover_a_deleted_certificate.json b/...restore_certificates_and_recover_backups/recording_can_recover_a_deleted_certificate.json
diff --git a/...client__restore_certificates_and_recover_backups/recording_can_restore_a_certificate.json b/...client__restore_certificates_and_recover_backups/recording_can_restore_a_certificate.json
diff --git a/...certificates_client__list_certificates_in_various_ways/recording_can_list_certificates.js b/...certificates_client__list_certificates_in_various_ways/recording_can_list_certificates.js
diff --git a/...ates_client__list_certificates_in_various_ways/recording_can_list_certificates_by_page.js b/...ates_client__list_certificates_in_various_ways/recording_can_list_certificates_by_page.js
diff --git a/...ates_client__list_certificates_in_various_ways/recording_can_list_deleted_certificates.js b/...ates_client__list_certificates_in_various_ways/recording_can_list_deleted_certificates.js
diff --git a/...ent__list_certificates_in_various_ways/recording_can_list_deleted_certificates_by_page.js b/...ent__list_certificates_in_various_ways/recording_can_list_deleted_certificates_by_page.js
diff --git a/...ficates_client__list_certificates_in_various_ways/recording_can_purge_all_certificates.js b/...ficates_client__list_certificates_in_various_ways/recording_can_purge_all_certificates.js
diff --git a/...dings/node/certificates_client__lro__delete/recording_can_resume_from_a_stopped_poller.js b/...dings/node/certificates_client__lro__delete/recording_can_resume_from_a_stopped_poller.js
diff --git a/...ode/certificates_client__lro__delete/recording_can_wait_until_a_certificate_is_deleted.js b/...ode/certificates_client__lro__delete/recording_can_wait_until_a_certificate_is_deleted.js
diff --git a/..._recoverdelete/recording_can_recover_a_deleted_certificate_with_requestoptions_timeout.js b/..._recoverdelete/recording_can_recover_a_deleted_certificate_with_requestoptions_timeout.js
diff --git a/...ode/certificates_client__lro__recoverdelete/recording_can_resume_from_a_stopped_poller.js b/...ode/certificates_client__lro__recoverdelete/recording_can_resume_from_a_stopped_poller.js
diff --git a/...ficates_client__lro__recoverdelete/recording_can_wait_until_a_certificate_is_recovered.js b/...ficates_client__lro__recoverdelete/recording_can_wait_until_a_certificate_is_recovered.js
diff --git a/...__restore_certificates_and_recover_backups/recording_can_recover_a_deleted_certificate.js b/...__restore_certificates_and_recover_backups/recording_can_recover_a_deleted_certificate.js
diff --git a/...s_client__restore_certificates_and_recover_backups/recording_can_restore_a_certificate.js b/...s_client__restore_certificates_and_recover_backups/recording_can_restore_a_certificate.js
diff --git a/...rtificates_and_recover_backups/recording_can_restore_a_key_with_requestoptions_timeout.js b/...rtificates_and_recover_backups/recording_can_restore_a_key_with_requestoptions_timeout.js
diff --git a/sdk/keyvault/keyvault-certificates/test/public/list.spec.ts b/sdk/keyvault/keyvault-certificates/test/public/list.spec.ts
@@ -70,7 +70,8 @@ describe("Certificates client - list certificates in various ways", () => {
     const certificateName = testClient.formatName(`${prefix}-${this!.test!.title}-${suffix}`);
     const certificateNames = [`${certificateName}0`, `${certificateName}1`];
     for (const name of certificateNames) {
-      await client.beginCreateCertificate(name, basicCertificatePolicy, testPollerProperties);
+      const createPoller = await client.beginCreateCertificate(name, basicCertificatePolicy, testPollerProperties);
+      await createPoller.pollUntilDone();
     }
 
     let found = 0;
@@ -91,7 +92,8 @@ describe("Certificates client - list certificates in various ways", () => {
     const certificateName = testClient.formatName(`${prefix}-${this!.test!.title}-${suffix}`);
     const certificateNames = [`${certificateName}0`, `${certificateName}1`];
     for (const name of certificateNames) {
-      await client.beginCreateCertificate(name, basicCertificatePolicy, testPollerProperties);
+      const createPoller = await client.beginCreateCertificate(name, basicCertificatePolicy, testPollerProperties);
+      await createPoller.pollUntilDone();
     }
     for (const name of certificateNames) {
       const deletePoller = await client.beginDeleteCertificate(name, testPollerProperties);
@@ -116,7 +118,8 @@ describe("Certificates client - list certificates in various ways", () => {
     const certificateName = testClient.formatName(`${prefix}-${this!.test!.title}-${suffix}`);
     const certificateNames = [`${certificateName}0`, `${certificateName}1`];
     for (const name of certificateNames) {
-      await client.beginCreateCertificate(name, basicCertificatePolicy, testPollerProperties);
+      const createPoller = await client.beginCreateCertificate(name, basicCertificatePolicy, testPollerProperties);
+      await createPoller.pollUntilDone();
     }
     let found = 0;
     for await (const page of client
@@ -148,7 +151,8 @@ describe("Certificates client - list certificates in various ways", () => {
     const certificateName = testClient.formatName(`${prefix}-${this!.test!.title}-${suffix}`);
     const certificateNames = [`${certificateName}0`, `${certificateName}1`];
     for (const name of certificateNames) {
-      await client.beginCreateCertificate(name, basicCertificatePolicy, testPollerProperties);
+      const createPoller = await client.beginCreateCertificate(name, basicCertificatePolicy, testPollerProperties);
+      await createPoller.pollUntilDone();
     }
     for (const name of certificateNames) {
       const deletePoller = await client.beginDeleteCertificate(name, testPollerProperties);

diff --git a/sdk/keyvault/keyvault-certificates/test/public/lro.delete.spec.ts b/sdk/keyvault/keyvault-certificates/test/public/lro.delete.spec.ts
@@ -35,11 +35,12 @@ describe("Certificates client - lro - delete", () => {
     const certificateName = testClient.formatName(
       `${certificatePrefix}-${this!.test!.title}-${certificateSuffix}`
     );
-    await client.beginCreateCertificate(
+    const createPoller = await client.beginCreateCertificate(
       certificateName,
       DefaultCertificatePolicy,
       testPollerProperties
     );
+    await createPoller.pollUntilDone();
     const poller = await client.beginDeleteCertificate(certificateName, testPollerProperties);
     assert.ok(poller.getOperationState().isStarted);
 
@@ -64,11 +65,12 @@ describe("Certificates client - lro - delete", () => {
     const certificateName = testClient.formatName(
       `${certificatePrefix}-${this!.test!.title}-${certificateSuffix}`
     );
-    await client.beginCreateCertificate(
+    const createPoller = await client.beginCreateCertificate(
       certificateName,
       DefaultCertificatePolicy,
       testPollerProperties
     );
+    await createPoller.pollUntilDone();
     const poller = await client.beginDeleteCertificate(certificateName, testPollerProperties);
     assert.ok(poller.getOperationState().isStarted);
 
@@ -100,4 +102,5 @@ describe("Certificates client - lro - delete", () => {
 
     await testClient.purgeCertificate(certificateName);
   });
+
 });
diff --git a/sdk/keyvault/keyvault-certificates/test/public/lro.recover.spec.ts b/sdk/keyvault/keyvault-certificates/test/public/lro.recover.spec.ts
@@ -36,30 +36,31 @@ describe("Certificates client - LRO - recoverDelete", () => {
     const certificateName = testClient.formatName(
       `${certificatePrefix}-${this!.test!.title}-${certificateSuffix}`
     );
-    await client.beginCreateCertificate(
+    const createPoller = await client.beginCreateCertificate(
       certificateName,
       DefaultCertificatePolicy,
       testPollerProperties
     );
+    await createPoller.pollUntilDone();
 
     const deletePoller = await client.beginDeleteCertificate(certificateName, testPollerProperties);
     await deletePoller.pollUntilDone();
 
-    const poller = await client.beginRecoverDeletedCertificate(
+    const recoverPoller = await client.beginRecoverDeletedCertificate(
       certificateName,
       testPollerProperties
     );
-    assert.ok(poller.getOperationState().isStarted);
+    assert.ok(recoverPoller.getOperationState().isStarted);
 
     // The pending certificate can be obtained this way:
-    assert.equal(poller.getOperationState().result!.name, certificateName);
+    assert.equal(recoverPoller.getOperationState().result!.name, certificateName);
 
-    const deletedCertificate: DeletedCertificate = await poller.pollUntilDone();
+    const deletedCertificate: DeletedCertificate = await recoverPoller.pollUntilDone();
     assert.equal(deletedCertificate.name, certificateName);
-    assert.ok(poller.getOperationState().isCompleted);
+    assert.ok(recoverPoller.getOperationState().isCompleted);
 
     // The final certificate can also be obtained this way:
-    assert.equal(poller.getOperationState().result!.name, certificateName);
+    assert.equal(recoverPoller.getOperationState().result!.name, certificateName);
 
     await testClient.flushCertificate(certificateName);
   });
@@ -68,40 +69,41 @@ describe("Certificates client - LRO - recoverDelete", () => {
     const certificateName = testClient.formatName(
       `${certificatePrefix}-${this!.test!.title}-${certificateSuffix}`
     );
-    await client.beginCreateCertificate(
+    const createPoller = await client.beginCreateCertificate(
       certificateName,
       DefaultCertificatePolicy,
       testPollerProperties
     );
+    await createPoller.pollUntilDone();
     const deletePoller = await client.beginDeleteCertificate(certificateName, testPollerProperties);
     await deletePoller.pollUntilDone();
 
-    const poller = await client.beginRecoverDeletedCertificate(
+    const recoverPoller = await client.beginRecoverDeletedCertificate(
       certificateName,
       testPollerProperties
     );
-    assert.ok(poller.getOperationState().isStarted);
+    assert.ok(recoverPoller.getOperationState().isStarted);
 
-    poller.pollUntilDone().catch((e) => {
+    recoverPoller.pollUntilDone().catch((e) => {
       assert.ok(e instanceof PollerStoppedError);
       assert.equal(e.name, "PollerStoppedError");
       assert.equal(e.message, "This poller is already stopped");
     });
 
-    await poller.poll(); // Making sure it has some data
+    await recoverPoller.poll(); // Making sure it has some data
 
-    poller.stopPolling();
-    assert.ok(poller.isStopped());
-    assert.ok(!poller.getOperationState().isCompleted);
+    recoverPoller.stopPolling();
+    assert.ok(recoverPoller.isStopped());
+    assert.ok(!recoverPoller.getOperationState().isCompleted);
 
-    const serialized = poller.toString();
+    const serialized = recoverPoller.toString();
 
     const resumePoller = await client.beginRecoverDeletedCertificate(certificateName, {
       resumeFrom: serialized,
       ...testPollerProperties
     });
 
-    assert.ok(poller.getOperationState().isStarted);
+    assert.ok(recoverPoller.getOperationState().isStarted);
     const deletedCertificate: DeletedCertificate = await resumePoller.pollUntilDone();
     assert.equal(deletedCertificate.name, certificateName);
     assert.ok(resumePoller.getOperationState().isCompleted);
@@ -115,11 +117,12 @@ describe("Certificates client - LRO - recoverDelete", () => {
     const certificateName = testClient.formatName(
       `${certificatePrefix}-${this!.test!.title}-${certificateSuffix}`
     );
-    await client.beginCreateCertificate(
+    const createPoller = await client.beginCreateCertificate(
       certificateName,
       DefaultCertificatePolicy,
       testPollerProperties
     );
+    await createPoller.pollUntilDone();
     const deletePoller = await client.beginDeleteCertificate(certificateName, testPollerProperties);
     await deletePoller.pollUntilDone();
     await assertThrowsAbortError(async () => {

diff --git a/sdk/keyvault/keyvault-certificates/test/public/recoverBackupRestore.spec.ts b/sdk/keyvault/keyvault-certificates/test/public/recoverBackupRestore.spec.ts
@@ -39,11 +39,12 @@ describe("Certificates client - restore certificates and recover backups", () =>
 
   it("can recover a deleted certificate", async function() {
     const certificateName = testClient.formatName(`${prefix}-${this!.test!.title}-${suffix}`);
-    await client.beginCreateCertificate(
+    const createPoller = await client.beginCreateCertificate(
       certificateName,
       basicCertificatePolicy,
       testPollerProperties
     );
+    await createPoller.pollUntilDone();
     const deletePoller = await client.beginDeleteCertificate(certificateName, testPollerProperties);
     const getDeletedResult = await deletePoller.pollUntilDone();
     assert.equal(
@@ -82,11 +83,12 @@ describe("Certificates client - restore certificates and recover backups", () =>
     // since the purge operation currently can't be expected to finish anytime soon.
     it("can restore a certificate", async function() {
       const certificateName = testClient.formatName(`${prefix}-${this!.test!.title}-${suffix}`);
-      await client.beginCreateCertificate(
+      const createPoller = await client.beginCreateCertificate(
         certificateName,
         basicCertificatePolicy,
         testPollerProperties
       );
+      await createPoller.pollUntilDone();
       const backup = await client.backupCertificate(certificateName);
       await testClient.flushCertificate(certificateName);
       // eslint-disable-next-line no-constant-condition
@@ -139,11 +141,12 @@ describe("Certificates client - restore certificates and recover backups", () =>
     // On playback mode, the tests happen too fast for the timeout to work
     it("can restore a key with requestOptions timeout", async function() {
       const certificateName = testClient.formatName(`${prefix}-${this!.test!.title}-${suffix}`);
-      await client.beginCreateCertificate(
+      const createPoller = await client.beginCreateCertificate(
         certificateName,
         basicCertificatePolicy,
         testPollerProperties
       );
+      await createPoller.pollUntilDone();
       const backup = await client.backupCertificate(certificateName);
       await testClient.flushCertificate(certificateName);