Skip to content

Commit

Permalink
[open-ai] Fix browser test command (#25945)
Browse files Browse the repository at this point in the history
`karma start karma.conf.cjs --single-run` would not start the
test-proxy.
We must rely on `dev-tool run test:browser` with additional args such
as..

`dev-tool run test:browser -- karma.conf.cjs`
  • Loading branch information
HarshaNalluru authored May 22, 2023
1 parent 1fb0d5a commit 2bbb02d
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 3 deletions.
2 changes: 1 addition & 1 deletion sdk/openai/openai/assets.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,5 +2,5 @@
"AssetsRepo": "Azure/azure-sdk-assets",
"AssetsRepoPrefixPath": "js",
"TagPrefix": "js/openai/openai",
"Tag": "js/openai/openai_415293cb60"
"Tag": "js/openai/openai_99dc8874ba"
}
3 changes: 1 addition & 2 deletions sdk/openai/openai/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -53,8 +53,7 @@
"test:browser": "npm run clean && npm run build && npm run integration-test:browser",
"test:node": "npm run clean && tsc -p . && npm run integration-test:node",
"test": "npm run clean && tsc -p . && npm run unit-test:node && dev-tool run bundle && npm run unit-test:browser && npm run integration-test",
"unit-test:browser": "echo skipped",
"unit-test:browser:debug": "karma start karma.conf.cjs --single-run",
"unit-test:browser": "dev-tool run test:browser -- karma.conf.cjs",
"unit-test:node": "dev-tool run test:node-ts-input -- \"test/internal/unit/{,!(browser)/**/}*.spec.ts\" \"test/public/{,!(browser)/**/}*.spec.ts\"",
"unit-test": "npm run unit-test:node && npm run unit-test:browser"
},
Expand Down

0 comments on commit 2bbb02d

Please sign in to comment.