Comment on casting partitionId

Azure · Jun 17, 2020 · a0cd335 · a0cd335
1 parent 2f443bc
commit a0cd335
Showing 1 changed file with 2 additions and 0 deletions.
diff --git a/sdk/eventhub/event-hubs/src/eventHubConsumerClient.ts b/sdk/eventhub/event-hubs/src/eventHubConsumerClient.ts
@@ -415,6 +415,8 @@ export class EventHubConsumerClient {
         validateEventPositions(options.startPosition);
       }
       ({ targetedPartitionId, eventProcessor } = this.createEventProcessorForSinglePartition(
+        // cast to string as downstream code expects partitionId to be string, but JS users could have given us anything.
+        // we don't validate the user input and instead rely on service throwing errors if any
         String(handlersOrPartitionId1),
         optionsOrHandlers2,
         possibleOptions3