SMB multichannel test only

sdk/storage/storage-file-share/karma.conf.js

@@ -62,6 +62,8 @@ module.exports = function(config) {
       "ACCOUNT_SAS",
       "SOFT_DELETE_ACCOUNT_NAME",
       "SOFT_DELETE_ACCOUNT_SAS",
+      "PREMIUM_FILE_ACCOUNT_NAME",
+      "PREMIUM_FILE_ACCOUNT_SAS",
       "TEST_MODE"
     ],
 

sdk/storage/storage-file-share/sample.env

@@ -19,8 +19,14 @@ DIR_NAME=<directory name>
 # change it to "record" to generate new recordings, or "live" to bypass the recorder entirely.
 # TEST_MODE=playback
 
-# Used for share soft delete.
+# Optional, used for share soft delete.
 SOFT_DELETE_ACCOUNT_NAME=<storage-account-name>
 SOFT_DELETE_ACCOUNT_KEY=<storage-account-key>
 SOFT_DELETE_STORAGE_CONNECTION_STRING=<storage-account-connection-string>
-SOFT_DELETE_ACCOUNT_SAS=<shared-access-signature>
+SOFT_DELETE_ACCOUNT_SAS=<shared-access-signature>
+
+# Optional, used for tests on premium file accounts.
+PREMIUM_FILE_ACCOUNT_NAME=<storage-account-name>
+PREMIUM_FILE_ACCOUNT_KEY=<storage-account-key>
+PREMIUM_FILE_STORAGE_CONNECTION_STRING=<storage-account-connection-string>
+PREMIUM_FILE_ACCOUNT_SAS=<shared-access-signature>

sdk/storage/storage-file-share/test/fileserviceclient.spec.ts

@@ -4,7 +4,8 @@ import {
   getBSU,
   getSASConnectionStringFromEnvironment,
   recorderEnvSetup,
-  getSoftDeleteBSU
+  getSoftDeleteBSU,
+  getGenericBSU
 } from "./utils";
 import { record, delay, Recorder } from "@azure/test-utils-recorder";
 import * as dotenv from "dotenv";
@@ -14,11 +15,11 @@ dotenv.config();
 describe("FileServiceClient", () => {
   let recorder: Recorder;
 
-  beforeEach(function () {
+  beforeEach(function() {
     recorder = record(this, recorderEnvSetup);
   });
 
-  afterEach(async function () {
+  afterEach(async function() {
     await recorder.stop();
   });
 
@@ -387,12 +388,11 @@ describe("FileServiceClient", () => {
   });
 });
 
-
 describe("FileServiceClient", () => {
   let recorder: Recorder;
   let serviceClient: ShareServiceClient;
 
-  beforeEach(function () {
+  beforeEach(function() {
     recorder = record(this, recorderEnvSetup);
 
     try {
@@ -402,11 +402,11 @@ describe("FileServiceClient", () => {
     }
   });
 
-  afterEach(async function () {
+  afterEach(async function() {
     await recorder.stop();
   });
 
-  it("ListShares with deleted share", async function () {
+  it("ListShares with deleted share", async function() {
     const shareClient = serviceClient.getShareClient(recorder.getUniqueName("share"));
     await shareClient.create();
     await shareClient.delete();
@@ -422,7 +422,7 @@ describe("FileServiceClient", () => {
     assert.ok(found);
   });
 
-  it("Undelete share positive", async function () {
+  it("Undelete share positive", async function() {
     const shareClient = serviceClient.getShareClient(recorder.getUniqueName("share"));
     await shareClient.create();
     await shareClient.delete();
@@ -455,7 +455,7 @@ describe("FileServiceClient", () => {
     await restoredShareClient.delete();
   });
 
-  it("Undelete share negative", async function () {
+  it("Undelete share negative", async function() {
     const shareClient = serviceClient.getShareClient(recorder.getUniqueName("share"));
     const invalidVersion = "01D60F8BB59A4652";
 
@@ -467,3 +467,29 @@ describe("FileServiceClient", () => {
     }
   });
 });
+
+describe("FileServiceClient Premium", () => {
+  let recorder: Recorder;
+  let serviceClient: ShareServiceClient;
+
+  beforeEach(function() {
+    recorder = record(this, recorderEnvSetup);
+    try {
+      serviceClient = getGenericBSU("PREMIUM_FILE_");
+    } catch (error) {
+      this.skip();
+    }
+  });
+
+  afterEach(async function() {
+    await recorder.stop();
+  });
+
+  it("SMB Multichannel", async () => {
+    await serviceClient.setProperties({
+      protocolSettings: { smbSettings: { multichannel: { enabled: true } } }
+    });
+    const propertiesSet = await serviceClient.getProperties();
+    assert.ok(propertiesSet.protocolSettings?.smbSettings?.multichannel);
+  });
+});

sdk/storage/storage-file-share/test/utils/testutils.common.ts

@@ -8,6 +8,7 @@ export function isBrowser(): boolean {
 const mockAccountName = "fakestorageaccount";
 const mockAccountKey = "aaaaa";
 const mockSDAccountName = "sd-fakestorageaccount";
+const mockPFAccountName = "pf-fakestorageaccount";
 export const recorderEnvSetup: RecorderEnvironmentSetup = {
          replaceableVariables: {
            // Used in record and playback modes
@@ -23,7 +24,11 @@ export const recorderEnvSetup: RecorderEnvironmentSetup = {
            SOFT_DELETE_ACCOUNT_NAME: `${mockSDAccountName}`,
            SOFT_DELETE_ACCOUNT_KEY: `${mockAccountKey}`,
            SOFT_DELETE_ACCOUNT_SAS: `${mockAccountKey}`,
-           SOFT_DELETE_STORAGE_CONNECTION_STRING: `DefaultEndpointsProtocol=https;AccountName=${mockSDAccountName};AccountKey=${mockAccountKey};EndpointSuffix=core.windows.net`
+           SOFT_DELETE_STORAGE_CONNECTION_STRING: `DefaultEndpointsProtocol=https;AccountName=${mockSDAccountName};AccountKey=${mockAccountKey};EndpointSuffix=core.windows.net`,
+           PREMIUM_FILE_ACCOUNT_NAME: `${mockPFAccountName}`,
+           PREMIUM_FILE_ACCOUNT_KEY: `${mockAccountKey}`,
+           PREMIUM_FILE_ACCOUNT_SAS: `${mockAccountKey}`,
+           PREMIUM_FILE_STORAGE_CONNECTION_STRING: `DefaultEndpointsProtocol=https;AccountName=${mockPFAccountName};AccountKey=${mockAccountKey};EndpointSuffix=core.windows.net`
          },
          customizationsOnRecordings: [
            // Used in record mode