Skip to content

Commit

Permalink
[Storage][Blob] explicitly re-export individual model types (#5567)
Browse files Browse the repository at this point in the history
* [Storage][Blob] explicitly re-export individual model types

This replaces `import * as Model` with explicitly importing types that we used
in public api surface. A geneartedModels.ts is added to import those types
aliased with Model suffix to indicate that they are from generated models.

This change brings several benefits, among them

- api-extractor now works fine to generate the api review markdown file
  `./review/storage-blob.api.md`. It is used to audit the public api changes. we
  now selectively

- export types from generated code instead of exporting everything.

* Fix merge conflicts
  • Loading branch information
jeremymeng authored and ramya-rao-a committed Oct 21, 2019
1 parent f00db6d commit e0fdc87
Show file tree
Hide file tree
Showing 20 changed files with 2,241 additions and 309 deletions.
4 changes: 3 additions & 1 deletion sdk/storage/storage-blob/BreakingChanges.md
Original file line number Diff line number Diff line change
@@ -1,9 +1,11 @@
# Breaking Changes

### 2019.10 12.0.0-preview.5
### 2019.11 12.0.0-preview.5

- `IPRange` is renamed to `SasIPRange`.

- `Models` is no longer exported in public API surface. Instead generated model types required by the public API are explicitly re-exported. In the case where convenience layer already defined a type with conflicting name, the model type is aliased with `Model` suffix.

### 2019.10 Version 12.0.0-preview.4

- Replace string array with boolean flags to specify dataset to include when list containers or blobs.
Expand Down
4 changes: 3 additions & 1 deletion sdk/storage/storage-blob/ChangeLog.md
Original file line number Diff line number Diff line change
@@ -1,9 +1,11 @@
# Changelog

## 2019.10 12.0.0-preview.5
## 2019.11 12.0.0-preview.5

- [Breaking] `IPRange` is renamed to `SasIPRange`.

- [Breaking] `Models` is no longer exported in public API surface. Instead generated model types required by the public API are explicitly re-exported. In the case where convenience layer already defined a type with conflicting name, the model type is aliased with `Model` suffix.

## 2019.10 12.0.0-preview.4

- [Breaking] Replace string array with boolean flags to specify dataset to include when listing containers or blobs.
Expand Down
Loading

0 comments on commit e0fdc87

Please sign in to comment.