Merge remote-tracking branch 'upstream/master' into eh-load-balance-v2

Azure · Jul 1, 2020 · fd5091d · fd5091d
2 parents c2c31a7 + 0190b5a
commit fd5091d
Show file tree

Hide file tree

Showing 629 changed files with 51,959 additions and 7,762 deletions.
diff --git a/common/config/rush/common-versions.json b/common/config/rush/common-versions.json
@@ -56,6 +56,8 @@
     "@azure/core-http": ["^1.1.1"],
 
     // Allow packages to continue to use old eslint-plugin-azure-sdk until they can adapt to 3.0.0
-    "@azure/eslint-plugin-azure-sdk": ["^2.0.1"]
+    "@azure/eslint-plugin-azure-sdk": ["^2.0.1"],
+    // Allow storage-blob-changefeed and storage-file-datalake to use the preview version of storage-blob.
+    "@azure/storage-blob": ["^12.2.0-rc.1"]
   }
 }
diff --git a/common/config/rush/pnpm-lock.yaml b/common/config/rush/pnpm-lock.yaml
diff --git a/common/tools/eslint-plugin-azure-sdk/src/configs/azure-sdk-base.ts b/common/tools/eslint-plugin-azure-sdk/src/configs/azure-sdk-base.ts
@@ -66,7 +66,10 @@ export default {
     "@typescript-eslint/interface-name-prefix": ["error", "never"],
     "@typescript-eslint/no-namespace": "off",
     "@typescript-eslint/no-non-null-assertion": "off",
-    "@typescript-eslint/no-unused-vars": "warn",
+    "@typescript-eslint/no-unused-vars": [
+      "warn",
+      { "argsIgnorePattern": "^_" }
+    ],
     "@typescript-eslint/no-useless-constructor": "error",
     "@typescript-eslint/no-use-before-define": "off",
     "@typescript-eslint/no-var-requires": "off",

diff --git a/dataplane.code-workspace b/dataplane.code-workspace
@@ -104,6 +104,10 @@
       "name": "storage-blob",
       "path": "sdk\\storage\\storage-blob"
     },
+    {
+      "name": "storage-blob-changefeed",
+      "path": "sdk\\storage\\storage-blob-changefeed"
+    },
     {
       "name": "storage-file-datalake",
       "path": "sdk\\storage\\storage-file-datalake"

diff --git a/eng/.docsettings.yml b/eng/.docsettings.yml
@@ -14,6 +14,7 @@ omitted_paths:
   - sdk/servicebus/*/test/README.md
   - sdk/servicebus/service-bus/samples-v1/*
   - sdk/storage/*/test/README.md
+  - sdk/storage/storage-internal-avro/*
   - sdk/textanalytics/*/test/README.md
   - sdk/**/samples/*
   - sdk/**/swagger/*
@@ -31,73 +32,97 @@ required_readme_sections:
   - ^Contributing$
 
 known_presence_issues:
-  - ['CHANGELOG.md','#1583']
-  - ['sdk/applicationinsights/applicationinsights-query/CHANGELOG.md','#1583']
-  - ['sdk/batch/batch/CHANGELOG.md','#1583']
-  - ['sdk/eventgrid/eventgrid/CHANGELOG.md','#1583']
-  - ['sdk/eventhub/testhub/CHANGELOG.md','#1583']
-  - ['sdk/graphrbac/graph/CHANGELOG.md','#1583']
-  - ['sdk/operationalinsights/loganalytics/CHANGELOG.md','#1583']
-  - ['sdk/servicefabric/servicefabric/CHANGELOG.md','#1583']
-  - ['sdk/storage/storage-datalake/CHANGELOG.md','#1583']
-  - ['sdk/template/template/CHANGELOG.md','#1583']
-  - ['sdk/test-utils/recorder/CHANGELOG.md','#1583']
-  - ['sdk/test-utils/perfstress/CHANGELOG.md','#1583']
+  - ["CHANGELOG.md", "#1583"]
+  - ["sdk/applicationinsights/applicationinsights-query/CHANGELOG.md", "#1583"]
+  - ["sdk/batch/batch/CHANGELOG.md", "#1583"]
+  - ["sdk/eventgrid/eventgrid/CHANGELOG.md", "#1583"]
+  - ["sdk/eventhub/testhub/CHANGELOG.md", "#1583"]
+  - ["sdk/graphrbac/graph/CHANGELOG.md", "#1583"]
+  - ["sdk/operationalinsights/loganalytics/CHANGELOG.md", "#1583"]
+  - ["sdk/servicefabric/servicefabric/CHANGELOG.md", "#1583"]
+  - ["sdk/storage/storage-datalake/CHANGELOG.md", "#1583"]
+  - ["sdk/template/template/CHANGELOG.md", "#1583"]
+  - ["sdk/test-utils/recorder/CHANGELOG.md", "#1583"]
+  - ["sdk/test-utils/perfstress/CHANGELOG.md", "#1583"]
 
 known_content_issues:
-  - ["README.md", "#1583"]
-  - ["sdk/appconfiguration/app-configuration/README.md", "#1583"]
-  - ["sdk/applicationinsights/applicationinsights-query/README.md", "#1583"]
-  - ["sdk/batch/batch/README.md", "#1583"]
-  - ["sdk/cognitiveservices/cognitiveservices-anomalydetector/README.md", "#1583",]
-  - ["sdk/cognitiveservices/cognitiveservices-autosuggest/README.md", "#1583"]
-  - ["sdk/cognitiveservices/cognitiveservices-computervision/README.md", "#1583"]
-  - ["sdk/cognitiveservices/cognitiveservices-contentmoderator/README.md", "#1583"]
-  - ["sdk/cognitiveservices/cognitiveservices-customimagesearch/README.md", "#1583"]
-  - ["sdk/cognitiveservices/cognitiveservices-customsearch/README.md", "#1583"]
-  - ["sdk/cognitiveservices/cognitiveservices-customvision-prediction/README.md", "#1583"]
-  - ["sdk/cognitiveservices/cognitiveservices-customvision-training/README.md", "#1583"]
-  - ["sdk/cognitiveservices/cognitiveservices-entitysearch/README.md", "#1583"]
-  - ["sdk/cognitiveservices/cognitiveservices-face/README.md", "#1583"]
-  - ["sdk/cognitiveservices/cognitiveservices-imagesearch/README.md", "#1583"]
-  - ["sdk/cognitiveservices/cognitiveservices-localsearch/README.md", "#1583"]
-  - ["sdk/cognitiveservices/cognitiveservices-luis-authoring/README.md", "#1583"]
-  - ["sdk/cognitiveservices/cognitiveservices-luis-runtime/README.md", "#1583"]
-  - ["sdk/cognitiveservices/cognitiveservices-newssearch/README.md", "#1583"]
-  - ["sdk/cognitiveservices/cognitiveservices-qnamaker/README.md", "#1583"]
-  - ["sdk/cognitiveservices/cognitiveservices-spellcheck/README.md", "#1583"]
-  - ["sdk/cognitiveservices/cognitiveservices-textanalytics/README.md", "#1583"]
-  - ["sdk/cognitiveservices/cognitiveservices-videosearch/README.md", "#1583"]
-  - ["sdk/cognitiveservices/cognitiveservices-visualsearch/README.md", "#1583"]
-  - ["sdk/cognitiveservices/cognitiveservices-websearch/README.md", "#1583"]
-  - ["sdk/core/abort-controller/README.md", "#1583"]
-  - ["sdk/core/core-auth/README.md", "#1583"]
-  - ["sdk/core/core-tracing/README.md", "#1583"]
-  - ["sdk/core/logger/README.md", "#1583"]
-  - ["sdk/cosmosdb/cosmos/README.md", "#1583"]
-  - ["sdk/cosmosdb/cosmos/test/readme.md", "#1583"]
-  - ["sdk/eventgrid/eventgrid/README.md", "#1583"]
-  - ["sdk/eventhub/event-hubs/README.md", "#1583"]
-  - ["sdk/eventhub/eventhubs-checkpointstore-blob/README.md", "#1583"]
-  - ["sdk/eventhub/event-processor-host/README.md", "#1583"]
-  - ["sdk/eventhub/README.md", "#1583"]
-  - ["sdk/eventhub/testhub/README.md", "#1583"]
-  - ["sdk/graphrbac/graph/README.md", "#1583"]
-  - ["sdk/keyvault/README.md", "#1583"]
-  - ["sdk/operationalinsights/loganalytics/README.md", "#1583"]
-  - ["sdk/servicebus/service-bus/README.md", "#1583"]
-  - ["sdk/servicebus/service-bus/test/README.md", "#1583"]
-  - ["sdk/servicefabric/servicefabric/README.md", "#1583"]
-  - ["sdk/storage/README.md", "#1583"]
-  - ["sdk/storage/storage-blob/test/README.md", "#1583"]
-  - ["sdk/storage/storage-datalake/README.md", "#1583"]
-  - ["sdk/storage/storage-file-datalake/test/README.md", "#1583"]
-  - ["sdk/storage/storage-file-share/test/README.md", "#1583"]
-  - ["sdk/storage/storage-queue/test/README.md", "#1583"]
-  - ["sdk/synapse/synapse/README.md", "#1583"]
-  - ["sdk/template/template/README.md", "#1583"]
-  - ["sdk/test-utils/recorder/README.md", "#1583"]
-  - ['sdk/test-utils/perfstress/CHANGELOG.md','#1583']
+  - ["README.md",  "#1583"]
+  - ["sdk/appconfiguration/app-configuration/README.md",  "#1583"]
+  - ["sdk/applicationinsights/applicationinsights-query/README.md",  "#1583"]
+  - ["sdk/batch/batch/README.md",  "#1583"]
+  - [
+      "sdk/cognitiveservices/cognitiveservices-anomalydetector/README.md",
+       "#1583",
+    ]
+  - ["sdk/cognitiveservices/cognitiveservices-autosuggest/README.md",  "#1583"]
+  - [
+      "sdk/cognitiveservices/cognitiveservices-computervision/README.md",
+       "#1583",
+    ]
+  - [
+      "sdk/cognitiveservices/cognitiveservices-contentmoderator/README.md",
+       "#1583",
+    ]
+  - [
+      "sdk/cognitiveservices/cognitiveservices-customimagesearch/README.md",
+       "#1583",
+    ]
+  - ["sdk/cognitiveservices/cognitiveservices-customsearch/README.md",  "#1583"]
+  - [
+      "sdk/cognitiveservices/cognitiveservices-customvision-prediction/README.md",
+       "#1583",
+    ]
+  - [
+      "sdk/cognitiveservices/cognitiveservices-customvision-training/README.md",
+       "#1583",
+    ]
+  - ["sdk/cognitiveservices/cognitiveservices-entitysearch/README.md",  "#1583"]
+  - ["sdk/cognitiveservices/cognitiveservices-face/README.md",  "#1583"]
+  - ["sdk/cognitiveservices/cognitiveservices-imagesearch/README.md",  "#1583"]
+  - ["sdk/cognitiveservices/cognitiveservices-localsearch/README.md",  "#1583"]
+  - [
+      "sdk/cognitiveservices/cognitiveservices-luis-authoring/README.md",
+       "#1583",
+    ]
+  - ["sdk/cognitiveservices/cognitiveservices-luis-runtime/README.md",  "#1583"]
+  - ["sdk/cognitiveservices/cognitiveservices-newssearch/README.md",  "#1583"]
+  - ["sdk/cognitiveservices/cognitiveservices-qnamaker/README.md",  "#1583"]
+  - ["sdk/cognitiveservices/cognitiveservices-spellcheck/README.md",  "#1583"]
+  - [
+      "sdk/cognitiveservices/cognitiveservices-textanalytics/README.md",
+       "#1583",
+    ]
+  - ["sdk/cognitiveservices/cognitiveservices-videosearch/README.md",  "#1583"]
+  - ["sdk/cognitiveservices/cognitiveservices-visualsearch/README.md",  "#1583"]
+  - ["sdk/cognitiveservices/cognitiveservices-websearch/README.md",  "#1583"]
+  - ["sdk/core/abort-controller/README.md",  "#1583"]
+  - ["sdk/core/core-auth/README.md",  "#1583"]
+  - ["sdk/core/core-tracing/README.md",  "#1583"]
+  - ["sdk/core/logger/README.md",  "#1583"]
+  - ["sdk/cosmosdb/cosmos/README.md",  "#1583"]
+  - ["sdk/cosmosdb/cosmos/test/readme.md",  "#1583"]
+  - ["sdk/eventgrid/eventgrid/README.md",  "#1583"]
+  - ["sdk/eventhub/event-hubs/README.md",  "#1583"]
+  - ["sdk/eventhub/eventhubs-checkpointstore-blob/README.md",  "#1583"]
+  - ["sdk/eventhub/event-processor-host/README.md",  "#1583"]
+  - ["sdk/eventhub/README.md",  "#1583"]
+  - ["sdk/eventhub/testhub/README.md",  "#1583"]
+  - ["sdk/graphrbac/graph/README.md",  "#1583"]
+  - ["sdk/keyvault/README.md",  "#1583"]
+  - ["sdk/operationalinsights/loganalytics/README.md",  "#1583"]
+  - ["sdk/servicebus/service-bus/README.md",  "#1583"]
+  - ["sdk/servicebus/service-bus/test/README.md",  "#1583"]
+  - ["sdk/servicefabric/servicefabric/README.md",  "#1583"]
+  - ["sdk/storage/README.md",  "#1583"]
+  - ["sdk/storage/storage-blob/test/README.md",  "#1583"]
+  - ["sdk/storage/storage-datalake/README.md",  "#1583"]
+  - ["sdk/storage/storage-file-datalake/test/README.md",  "#1583"]
+  - ["sdk/storage/storage-file-share/test/README.md",  "#1583"]
+  - ["sdk/storage/storage-queue/test/README.md",  "#1583"]
+  - ["sdk/synapse/synapse/README.md",  "#1583"]
+  - ["sdk/template/template/README.md",  "#1583"]
+  - ["sdk/test-utils/recorder/README.md",  "#1583"]
+  - ["sdk/test-utils/perfstress/CHANGELOG.md", "#1583"]
 
 package_indexing_exclusion_list:
   - "@azure/template"

diff --git a/eng/pipelines/templates/stages/archetype-js-release.yml b/eng/pipelines/templates/stages/archetype-js-release.yml
@@ -33,7 +33,7 @@ stages:
                       parameters:
                         SourceFolder: ${{parameters.ArtifactName}}
                         TargetFolder: ${{artifact.safeName}}
-                        PackageName: ${{artifact.name}}
+                        PackageName: ${{artifact.name}}-*.tgz
                     - pwsh: |
                         Get-ChildItem -Recurse $(Pipeline.Workspace)/${{artifact.safeName}}
                       workingDirectory: $(Pipeline.Workspace)
@@ -93,7 +93,7 @@ stages:
                         parameters:
                           SourceFolder: ${{parameters.ArtifactName}}
                           TargetFolder: ${{artifact.safeName}}
-                          PackageName: ${{artifact.name}}
+                          PackageName: ${{artifact.name}}-*.tgz
                       - pwsh: |
                           Get-ChildItem -Recurse $(Pipeline.Workspace)/${{artifact.safeName}}
                         workingDirectory: $(Pipeline.Workspace)
@@ -135,7 +135,7 @@ stages:
                         parameters:
                           SourceFolder: ${{parameters.DocArtifact}}
                           TargetFolder: ${{artifact.safeName}}/${{parameters.DocArtifact}}
-                          PackageName: $(Documentation.Zip)
+                          PackageName: $(Documentation.Zip).zip
                       - pwsh: |
                           Get-ChildItem -Recurse $(Pipeline.Workspace)/${{artifact.safeName}}
                         workingDirectory: $(Pipeline.Workspace)

diff --git a/eng/pipelines/templates/steps/stage-artifacts.yml b/eng/pipelines/templates/steps/stage-artifacts.yml
@@ -6,5 +6,5 @@ parameters:
 steps:
   - pwsh: |
       New-Item -Type Directory -Name ${{parameters.TargetFolder}} -Path $(Pipeline.Workspace)
-      Copy-Item $(Pipeline.Workspace)/${{parameters.SourceFolder}}/${{parameters.PackageName}}* $(Pipeline.Workspace)/${{parameters.TargetFolder}}
-    displayName: Stage artifacts
+      Copy-Item $(Pipeline.Workspace)/${{parameters.SourceFolder}}/${{parameters.PackageName}} $(Pipeline.Workspace)/${{parameters.TargetFolder}}
+    displayName: Stage artifacts
diff --git a/rush.json b/rush.json
@@ -462,11 +462,21 @@
       "projectFolder": "sdk/servicebus/service-bus",
       "versionPolicyName": "client"
     },
+    {
+      "packageName": "@azure/storage-internal-avro",
+      "projectFolder": "sdk/storage/storage-internal-avro",
+      "versionPolicyName": "utility"
+    },
     {
       "packageName": "@azure/storage-blob",
       "projectFolder": "sdk/storage/storage-blob",
       "versionPolicyName": "client"
     },
+    {
+      "packageName": "@azure/storage-blob-changefeed",
+      "projectFolder": "sdk/storage/storage-blob-changefeed",
+      "versionPolicyName": "client"
+    },
     {
       "packageName": "@azure/storage-file-share",
       "projectFolder": "sdk/storage/storage-file-share",
@@ -508,4 +518,4 @@
       "versionPolicyName": "utility"
     }
   ]
-}
+}
diff --git a/sdk/appconfiguration/app-configuration/README.md b/sdk/appconfiguration/app-configuration/README.md
@@ -16,19 +16,18 @@ Use the client library for App Configuration to:
 
 ## Getting started
 
-### Currently supported environments
-
-- Node.js version 8.x.x or higher
-
-**Prerequisites**: You must have an [Azure Subscription](https://azure.microsoft.com) and an [App Configuration](https://docs.microsoft.com/en-us/azure/azure-app-configuration/) resource to use this package.
-
-### 1. Install the `@azure/app-configuration` package
+### Install the package
 
 ```bash
 npm install @azure/app-configuration
 ```
 
-### 2. Create an App Configuration resource
+### Prerequisites
+
+- You must have an [Azure Subscription](https://azure.microsoft.com) and an [App Configuration](https://docs.microsoft.com/en-us/azure/azure-app-configuration/) resource to use this package.
+- Node.js version 8.x.x or higher
+
+### Create an App Configuration resource
 
 You can use the [Azure Portal](https://portal.azure.com) or the [Azure CLI](https://docs.microsoft.com/cli/azure) to create an Azure App Configuration resource.
 
@@ -38,31 +37,32 @@ Example (Azure CLI):
 az appconfig create --name <app-configuration-resource-name> --resource-group <resource-group-name> --location eastus
 ```
 
-### 3. Create and authenticate an `AppConfigurationClient`
+### Authenticate the client
 
 AppConfigurationClient can authenticate using a [service principal](#authenticating-with-a-service-principal) or using a [connection string](#authenticating-with-a-connection-string).
 
-####  Authenticating with a service principal
+#### Authenticating with a service principal
 
 Authentication via service principal is done by:
-* Creating a credential using the `@azure/identity` package.
-* Setting appropriate RBAC rules on your AppConfiguration resource.
-   More information on App Configuration roles can be found [here](https://github.com/Azure/AppConfiguration/blob/master/docs/REST/authorization/aad.md).
+
+- Creating a credential using the `@azure/identity` package.
+- Setting appropriate RBAC rules on your AppConfiguration resource.
+  More information on App Configuration roles can be found [here](https://github.com/Azure/AppConfiguration/blob/master/docs/REST/authorization/aad.md).
 
 Using [DefaultAzureCredential](https://github.com/Azure/azure-sdk-for-js/blob/master/sdk/identity/identity/README.md#defaultazurecredential)
 
 ```javascript
-  const azureIdentity= require("@azure/identity");
-  const appConfig = require("@azure/app-configuration");
-
-  const credential = new azureIdentity.DefaultAzureCredential();
-  const client = new appConfig.AppConfigurationClient(
-      endpoint, // ex: <https://<your appconfig resource>.azconfig.io>
-      credential
-  );
+const azureIdentity = require("@azure/identity");
+const appConfig = require("@azure/app-configuration");
+
+const credential = new azureIdentity.DefaultAzureCredential();
+const client = new appConfig.AppConfigurationClient(
+  endpoint, // ex: <https://<your appconfig resource>.azconfig.io>
+  credential
+);
 ```
 
- More information about `@azure/identity` can be found [here](https://github.com/Azure/azure-sdk-for-js/blob/master/sdk/identity/identity/README.md)
+More information about `@azure/identity` can be found [here](https://github.com/Azure/azure-sdk-for-js/blob/master/sdk/identity/identity/README.md)
 
 #### Authenticating with a connection string
 

diff --git a/sdk/core/core-http/.eslintrc.json b/sdk/core/core-http/.eslintrc.json
@@ -1,7 +1,11 @@
 {
   "plugins": ["@azure/azure-sdk"],
-  "extends": ["../../.eslintrc.old.json", "plugin:@azure/azure-sdk/recommended"],
-  "parserOptions": {
-    "createDefaultProgram": true
+  "extends": ["plugin:@azure/azure-sdk/azure-sdk-base"],
+  "rules": {
+    "@azure/azure-sdk/ts-use-interface-parameters": "off",
+    "@azure/azure-sdk/ts-apiextractor-json-types": "off",
+    "@azure/azure-sdk/ts-package-json-types": "off",
+    "@azure/azure-sdk/ts-package-json-module": "off",
+    "@azure/azure-sdk/ts-package-json-files-required": "off"
   }
 }