Fix ESLint issues in Appconfiguration packages

[praveenkuttappan]

Fix lint errors found in app-configuration package by ESLint. Following are the steps to run ESLint for appconfiguration package and reproduce this issue.

1. Set up your dev environment if not already done so as mentioned here
2. Go to <repo root>/sdk/appconfiguration/app-configuration
3. run rushx lint
4. Command in step 2) generates an html report in directory <repo root>/sdk/appconfiguration/app-configuration with name ends with lintReport.html
5. All lint errors found in this package is listed on html report.

Once all known issues are resolved, below change is required in package.json file in package root <repo root>/sdk/appconfiguration/app-configuration to treat any new lint regression as hard failure in CI.

• Remove following snippet from lint command in package.json
-f html -o template-lintReport.html || exit 0

Note: HTML report name prefix may be different for each package name to differentiate the report for each package.

[sadasant]

Hello @praveenkuttappan !

When is this due? I don't think I will have time to do this this early in the week. Perhaps another team member could? In any case, I've added this to my backlog.