[ESLint plugin] Check if sdk-type exists in package.json
#13214
Labels
eslint plugin
help wanted
This issue is tracking work for which community contributions would be welcomed and appreciated
Comments
openapi-sdkautomation bot
pushed a commit
to AzureSDKAutomation/azure-sdk-for-js
that referenced
this issue
Mar 16, 2021
2021 preview sb (Azure#13214) * Add 2018 files as base commit * Change files for 2021 in base files * swagger fix lintdiff errors * Add private endpoint connection property and refresh get example * add python2 in readme * Add checknamespaceavailability 2018 as base commit * Change checknamespaceavaibility for 2021-preview * fix track2 pipeline issue * fix lintdiff error * fix spell check
deyaaeldeen
added
the
help wanted
This was referenced Nov 7, 2021
maorleger
pushed a commit
that referenced
this issue
Nov 10, 2021
…on (#18597) This fixes #13214. This PR is an update from a past PR, #18565. What's new? - I updated ```ts-package-json-sdktype.ts``` to enforce the existence of```sdk-type``` and that it is either ```client``` or ```mgmt```. If it does not, then the linter will throw an error. - I added/updated appropriate tests and verified the entire repository using ```rush lint``` - I also put the rules in the correct files (```src/configs/index.ts, src/rules/index.ts```, and ```tests/plugin.ts```) - I have written a docs file to put in ```docs/rules``` which are now included in the commit! - I do need to still update the actual ```README.md``` file, but I'm not sure what the actual version is (hopefully this isn't too much trouble)
danieljurek
pushed a commit
that referenced
this issue
Nov 10, 2021
…on (#18597) This fixes #13214. This PR is an update from a past PR, #18565. What's new? - I updated ```ts-package-json-sdktype.ts``` to enforce the existence of```sdk-type``` and that it is either ```client``` or ```mgmt```. If it does not, then the linter will throw an error. - I added/updated appropriate tests and verified the entire repository using ```rush lint``` - I also put the rules in the correct files (```src/configs/index.ts, src/rules/index.ts```, and ```tests/plugin.ts```) - I have written a docs file to put in ```docs/rules``` which are now included in the commit! - I do need to still update the actual ```README.md``` file, but I'm not sure what the actual version is (hopefully this isn't too much trouble)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Client packages should have
"sdk-type": "clientinpackage.json. This check could be implemented as a new rule in the ESLint Plugin.Code pointers for anyone wanting to fix this:
The text was updated successfully, but these errors were encountered: