Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Identity] Enable live tests #14367

Closed
4 tasks done
sadasant opened this issue Mar 18, 2021 · 3 comments
Closed
4 tasks done

[Identity] Enable live tests #14367

sadasant opened this issue Mar 18, 2021 · 3 comments
Assignees
@sadasant
Labels
Azure.Identity Client This issue points to a problem in the data-plane of the library.
Milestone
[2022] April

Comments

@sadasant
Copy link
Contributor

sadasant commented Mar 18, 2021 •
edited
Loading

With this PR: #14064 Identity should be ready to have live tests enabled.

Here are some reasonable steps I can think of:

  • Make a live test pipeline for Identity.
  • Add the missing files required to run the live tests.
    • One file will be the test-resources.json. Keep in mind that while we don't need resources, the account used for the live tests will need to have a certificate associated and provided through environment variables, and a username and password should also be provided via environment variables. The env variable names I'm using are: AZURE_CLIENT_ID, AZURE_TENANT_ID, AZURE_CLIENT_SECRET, AZURE_CLIENT_CERTIFICATE_PATH, AZURE_USERNAME, AZURE_PASSWORD
  • Test that live tests are working in a pull request.
@sadasant sadasant added EngSys This issue is impacting the engineering system. Azure.Identity labels Mar 18, 2021
@sadasant sadasant added this to the [2021] April milestone Mar 18, 2021
@praveenkuttappan praveenkuttappan removed their assignment Mar 25, 2021
@praveenkuttappan
Copy link
Member

resource deployment json file needs to be prepared and merged before we can create live test.

@sadasant sadasant modified the milestones: [2021] April, 2021 May, [2021] May, [2021] June Mar 31, 2021
@sadasant sadasant modified the milestones: [2021] June, [2021] July May 11, 2021
@ramya-rao-a
Copy link
Contributor

@sadasant How is this different from #10963?

openapi-sdkautomation bot pushed a commit to AzureSDKAutomation/azure-sdk-for-js that referenced this issue Jun 4, 2021
CodeGen from PR 14367 in Azure/azure-rest-api-specs
04dccba 
Azure key vault import keys json to 2021-04-01-preview (Azure#14367)

* Import keys.json with rotation policy parameters

* Update

* Fixed spelling

* prettier fix

* Remove keyrotationpolicy parameters

* Change type name
@sadasant sadasant mentioned this issue Jul 6, 2021
Closed
@sadasant
Copy link
Contributor Author

sadasant commented Jul 6, 2021

I’ll push this to the backlog since I don’t believe we’ll be able to get to this before GA.

@sadasant sadasant modified the milestones: [2021] August, Backlog Jul 6, 2021
@ramya-rao-a ramya-rao-a added Client This issue points to a problem in the data-plane of the library. and removed EngSys This issue is impacting the engineering system. labels Jul 26, 2021
@sadasant sadasant modified the milestones: Backlog, [2022] April Mar 10, 2022
@sadasant sadasant mentioned this issue Mar 10, 2022
Merged
sadasant added a commit that referenced this issue Mar 25, 2022
@sadasant
[Identity] Changes to increase live test coverage (#20729)
3043b2e 
Improving Identity’s Live Test coverage by reproducing .NET’s configuration files and mapping the environment variables correctly.

Related to: #14367
@github-actions github-actions bot locked and limited conversation to collaborators Apr 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@sadasant sadasant

Labels
Azure.Identity Client This issue points to a problem in the data-plane of the library.
Projects
None yet
Milestone
[2022] April
Development

No branches or pull requests
3 participants
@sadasant @ramya-rao-a @praveenkuttappan