Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Identity] Browser tests #14913

Closed
HarshaNalluru opened this issue Apr 16, 2021 · 3 comments
Closed

[Identity] Browser tests #14913

HarshaNalluru opened this issue Apr 16, 2021 · 3 comments
Assignees
Labels
Azure.Identity Client This issue points to a problem in the data-plane of the library.

Comments

@HarshaNalluru
Copy link
Member

HarshaNalluru commented Apr 16, 2021

Currently, the identity package doesn't have run the browser tests (echo skipped).
However, individual SDKs use ClientSecretCredential with disabled security in the browser through karma conf.

  • We should find a way to test with the InteractiveBrowserCredential in the CI, and get rid of the ClientSecretCredential in our browser tests. (Also consider how the recorder would play in this scenario.)
  • If we are relying on ClientSecretCredential for a longer period for testing in the browsers, we should add browser tests in the identity package similar to what we have in the individual SDKs to figure out the things that might break the browsers so that it would help find the regressions sooner than when we import the identity library in our SDKs. Reference - [Identity] Reverting ClientSecretCredential and UsernamePasswordCredential to v1 only for browsers, and fixing Karma browser bundles #14910
@ghost ghost added the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Apr 16, 2021
@ramya-rao-a ramya-rao-a added Azure.Identity Client This issue points to a problem in the data-plane of the library. labels Apr 19, 2021
@ghost ghost removed the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Apr 19, 2021
@ramya-rao-a ramya-rao-a added this to the Backlog milestone Apr 19, 2021
@ramya-rao-a ramya-rao-a modified the milestones: Backlog, [2021] August May 20, 2021
@sadasant
Copy link
Contributor

For context:

  • Testing InteractiveBrowserCredential isn’t trivial with our current setup because the page that has Karma loaded needs to redirect to Azure, then come back, losing Karma’s state and potentially encountering other errors.
  • In the link that Karishma shared above, I’m starting to test how to use “puppeteer” to test these interactive credentials.
    • Puppeteer (or other libraries, like Casper.js) allow Node.js to manage browser tabs. They follow through redirections.
    • Even if testing is viable with Puppeteer, we still need to figure out how to make it work nicely with our current testing infrastructure.

My current thoughts are that I could start playing with Puppeteer while I work on the new features for the browser experience for JS, and once we have a reliable experience there (separate from our SDK repo), we could present it to the team.

Copy link

Hi @HarshaNalluru, we deeply appreciate your input into this project. Regrettably, this issue has remained inactive for over 2 years, leading us to the decision to close it. We've implemented this policy to maintain the relevance of our issue queue and facilitate easier navigation for new contributors. If you still believe this topic requires attention, please feel free to create a new issue, referencing this one. Thank you for your understanding and ongoing support.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Mar 18, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Mar 18, 2024
@xirzec xirzec removed this from the Backlog milestone May 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Azure.Identity Client This issue points to a problem in the data-plane of the library.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants