[Identity] Two Playwright tests for the InteractiveBrowserCredential #21171
Conversation
|
API change check for API changes are not detected in this pull request for |
| @@ -52,7 +52,8 @@ | |||
| "check-format": "prettier --list-different --config ../../../.prettierrc.json --ignore-path ../../../.prettierignore \"src/**/*.ts\" \"test/**/*.ts\" \"samples-dev/**/*.ts\" \"*.{js,json}\"", | |||
| "integration-test:browser": "echo skipped", | |||
| "integration-test:node": "dev-tool run test:node-js-input -- --timeout 180000 'dist-esm/test/public/node/*.spec.js' 'dist-esm/test/internal/node/*.spec.js'", | |||
| "integration-test": "npm run integration-test:node && npm run integration-test:browser", | |||
| "integration-test:playwright": "rimraf dist-playwright && npx playwright install && tsc -p playwright.tsconfig.json && rollup --config && playwright test -c dist-playwright", | |||
| "integration-test": "npm run integration-test:node && npm run integration-test:browser && npm run integration-test:playwright", | |||
There was a problem hiding this comment.
I’m having a hard time imagining how to merge this with our current setup 😅
| @@ -33,3 +33,4 @@ stages: | |||
| IDENTITY_SP_CERT_SNI: $(Agent.TempDirectory)/testsni.pfx | |||
| IDENTITY_SP_CERT_SNI_PEM: $(Agent.TempDirectory)/testsni.pem | |||
| IDENTITY_PEM_CONTENTS: $(net-identity-spcert-pem) | |||
| AZURE_IDENTITY_BROWSER_CLIENT_ID: $(identity-azure-sdk-js-test-browser-client-id) | |||
There was a problem hiding this comment.
We need to create an app registration with an “spa” redirect endpoint and store its client ID in the keyvault used for the CI en variables 🙂
| @@ -52,7 +52,8 @@ | |||
| "check-format": "prettier --list-different --config ../../../.prettierrc.json --ignore-path ../../../.prettierignore \"src/**/*.ts\" \"test/**/*.ts\" \"samples-dev/**/*.ts\" \"*.{js,json}\"", | |||
| "integration-test:browser": "echo skipped", | |||
| "integration-test:node": "dev-tool run test:node-js-input -- --timeout 180000 'dist-esm/test/public/node/*.spec.js' 'dist-esm/test/internal/node/*.spec.js'", | |||
| "integration-test": "npm run integration-test:node && npm run integration-test:browser", | |||
| "integration-test:playwright": "rimraf dist-playwright && npx playwright install && tsc -p playwright.tsconfig.json && rollup --config && playwright test -c dist-playwright", | |||
There was a problem hiding this comment.
npx playwright install ensures that the web browser needed for testing is installed. Playwright doesn’t do that by default when you install it.
| // Copyright (c) Microsoft Corporation. | ||
| // Licensed under the MIT license. | ||
|
|
||
| export { InteractiveBrowserCredential } from "../../../../src/credentials/interactiveBrowserCredential.browser"; |
There was a problem hiding this comment.
If I were to do this in another project, other than our SDK repo, I would load here the @azure/identity package, like:
export { InteractiveBrowserCredential } from "@azure/identity";
| <html> | ||
| <head> | ||
| <meta charset="utf-8" /> | ||
| <!-- /index.js is a route defined in the Express.js server --> |
There was a problem hiding this comment.
| <!-- /index.js is a route defined in the Express.js server --> | |
| <!-- /index.js is a route defined in the Express.js server --> |
| <!-- /index.js is a route defined in the Express.js server --> | |
| <!-- /index.js is a route defined in the Express.js server --> |
ghost
added
the
no-recent-activity
|
Hi @sadasant. Thank you for your interest in helping to improve the Azure SDK experience and for your contribution. We've noticed that there hasn't been recent engagement on this pull request. If this is still an active work stream, please let us know by pushing some changes or leaving a comment. Otherwise, we'll close this out in 7 days. |
ghost
closed this
|
Hi @sadasant. Thank you for your contribution. Since there hasn't been recent engagement, we're going to close this out. Feel free to respond with a comment containing "/reopen" if you'd like to continue working on these changes. Please be sure to use the command to reopen or remove the "no-recent-activity" label; otherwise, this is likely to be closed again with the next cleanup pass. |
add or modify files (Azure#21171)
Playwright tests for the interactive browser credential.
Fixes #21166
Also arguably:
Fixes #14913
Fixes #14368