Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Text Analytics] Add support for sentiment analysis actions #15128

Closed
deyaaeldeen opened this issue May 4, 2021 · 0 comments · Fixed by #14808
Closed

[Text Analytics] Add support for sentiment analysis actions #15128

deyaaeldeen opened this issue May 4, 2021 · 0 comments · Fixed by #14808
Assignees
@deyaaeldeen
Labels
Client This issue points to a problem in the data-plane of the library. Cognitive - Text Analytics
Milestone
[2021] May

Comments

@deyaaeldeen
Copy link
Member

No description provided.

@deyaaeldeen deyaaeldeen added this to the [2021] May milestone May 4, 2021
@deyaaeldeen deyaaeldeen self-assigned this May 4, 2021
@ramya-rao-a ramya-rao-a added the Client This issue points to a problem in the data-plane of the library. label May 4, 2021
@deyaaeldeen deyaaeldeen mentioned this issue May 5, 2021
Merged
@ghost ghost closed this as completed in #14808 May 12, 2021
ghost pushed a commit that referenced this issue May 12, 2021
@deyaaeldeen
[Text Analytics] Generate using swagger for endpoint v3.1-preview.5 (#…
3a9b195 
…14808)

- adds support for new text analytics in v3.1-preview.5. Fixes #15128
- removes the word `batch` to simplify names and avoid confusion after talking with @xirzec and the crew. Fixes #15127
- add test cases for analyze sentiment and recognize linked entities actions
- update tests for action validation to match new strict validation behavior in the service in the post request
- re-enable some disabled tests now that the service fixed those issues
- disabled the statistics test for `beginAnalyzeActions` because of wrong answers coming from the service and it is currently being investigated
- the CI failures are because the service did not deploy healthcare API yet so this PR can not be merged until then but please review it.
- removed the logic for setting model version even if the user does not specify yet. This logic was needed because of a service-side bug that is now fixed. Fixes #14079

[API View](https://apiview.dev/Assemblies/Review/8754191c44914b7e88232f8aba5073de?diffRevisionId=43c78776e4a6490aa4009fb1035ec44d&doc=False&diffOnly=False)
[Swagger PR](Azure/azure-rest-api-specs#13851)
@github-actions github-actions bot locked and limited conversation to collaborators Apr 12, 2023
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@deyaaeldeen deyaaeldeen

Labels
Client This issue points to a problem in the data-plane of the library. Cognitive - Text Analytics
Projects
None yet
Milestone
[2021] May
Development

Successfully merging a pull request may close this issue.

[Text Analytics] Generate using swagger for endpoint v3.1-preview.5 deyaaeldeen/azure-sdk-for-js
2 participants
@deyaaeldeen @ramya-rao-a