-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Azure schema registry SDK does not have a way to check if a new schema is compatible #15154
Comments
Thanks again for your feedback, @dhoepelman Adding @hmlam for service perspective. |
Thanks for the feedback. this requirement is something that we are aware of, and it is in our backlog of design items to go through as we get closer to GA the service. |
[AKS] Merge dev-containerservice-Microsoft.ContainerService-2021-07-01 to master (Azure#15370) * Adds base for updating Microsoft.ContainerService from version stable/2021-05-01 to version 2021-07-01 * Updates readme * Updates API version in new specs and examples * Modify Swagger to fix the problem of automatically generating ugly names in track 2 (Azure#14758) * update swagger to fix track 2 autogenerated naming issue * fix * update readme for sdk generation * fix lint error * Trigger Build * update readme * Improve AKS Swagger documentation (Azure#14957) * Improve AKS Swagger documentation - This change has already been merged in master for the 2021-05-01 API version. * Fix up custom words * aks: replace CloudError with ManagedClusterPodIdentityProvisioningError for AAD pod identity provisioning spec (Azure#15033) * fix: decouple pod identity provisioning error from cloud error * drop extra external mark * fix linting issue * fix reference * Dev containerservice microsoft.container service 2021 07 01: add SecurityProfile (Azure#15035) * Add SecurityProfile to ManagedClusters * spaces * Space * spaces * json formatting * move from params to defs * :) * just another * now with npm * Descriptions update for AKS July API (Azure#15074) * allow disabling of runcommand (Azure#15092) * allow disabling of runcommand * format error * format with example * change enable to disable * Revert "allow disabling of runcommand (Azure#15092)" (Azure#15147) This reverts commit ec3e241a564d21f5ec914f4aa0b59a96ac7ec0d9. * [AKS] Add NATGatewayProfile to 2021-07-01 API (Azure#15154) * [AKS] Add NATGatewayProfile to 2021-07-01 API * Fix linter errors Co-authored-by: Kaiqi Zhang <kaiqzhan@microsoft.com> * Add scaleDownMode to agent pool properties (Azure#15124) * add scale down mode * address comments * fix markdown link * update proper api version * Resolve python markdown conflict & fix typo (Azure#15402) * resolve python conflict & fix typo * resolve conflict Co-authored-by: FumingZhang <81607949+FumingZhang@users.noreply.github.com> Co-authored-by: Matthew Christopher <matthchr@microsoft.com> Co-authored-by: hbc <bcxxxxxx@gmail.com> Co-authored-by: Or Parnes <orparnes@gmail.com> Co-authored-by: Haitao Chen <haitch@users.noreply.github.com> Co-authored-by: Kaiqi Zhang <kaiqzhan@microsoft.com> Co-authored-by: Marwan Ahmed <marwanad@microsoft.com> Co-authored-by: Arthur Ning <57385816+akning-ms@users.noreply.github.com>
Hi @dhoepelman, we deeply appreciate your input into this project. Regrettably, this issue has remained inactive for over 2 years, leading us to the decision to close it. We've implemented this policy to maintain the relevance of our issue queue and facilitate easier navigation for new contributors. If you still believe this topic requires attention, please feel free to create a new issue, referencing this one. Thank you for your understanding and ongoing support. |
Is your feature request related to a problem? Please describe.
We want to signal in our build pipeline at PR time if a new schema introduced is incompatible with the existing one, according to the rules set in the schema registry.
We encountered 2 limitations: there doesn't seem to be an API method to check if a schema is compatible without actually registering it (this would require additional server support)).
Furthermore, when actually registering the schema the error message is not very clear. Just as with #15130 I'd consider trying to register an incompatible schema a functional user error that warrants it's own handling.
Describe the solution you'd like
A dedicated method like would be ideal for our use-case
For
registerSchema
, the problem is that there's not straightforward way to check this error condition. A rejected promise with a custom exception feels best to meDescribe alternatives you've considered
If a
isSchemaCompatible
method is introduced the need to changeregisterSchema
becomes greatly reduces, as one can always first callisSchemaCompatible
before callingregisterSchema
.You could change the registerSchema signature to incorporate this functional error, but it doesn't feel right to me as this is an exceptional case for this method
{ details: { body: { Code: 400, Detail: /^Schema validation failed: .* compatibility test failed.*/ } }
The text was updated successfully, but these errors were encountered: