Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dev-tool] check-node-versions fails when using --node-versions flag without --node-version #16657

Closed
maorleger opened this issue Jul 29, 2021 · 0 comments · Fixed by #16686
Closed
Assignees
Labels
Client This issue points to a problem in the data-plane of the library. dev-tool Issues related to the Azure SDK for JS dev-tool
Milestone

Comments

@maorleger
Copy link
Member

When using only node-versions without node-version you end up with the trailing empty string here which causes downstream errors when building docker container names.

> options = { "node-versions": "12,13,14,15", "node-version": "" }
{ 'node-versions': '12,13,14,15', 'node-version': '' }
> [...new Set(options["node-versions"]?.split(",").concat(options["node-version"]))]
[ '12', '13', '14', '15', '' ]

Showing the errors as well, because it's a good hint to what's happening

[check-node-versions-samples] docker: Error response from daemon: Conflict. The container name "/12-container" is already in use by container "9e702026ecaa87a8c40a54735611d00b9f3f31fe6e251913687b520dfa2891c6". You have to remove (or rename) that container to be able to reuse that name.
See 'docker run --help'.
[check-node-versions-samples] Docker container 12-container encountered an error
[check-node-versions-samples] docker: Error response from daemon: Conflict. The container name "/12-container" is already in use by container "9e702026ecaa87a8c40a54735611d00b9f3f31fe6e251913687b520dfa2891c6". You have to remove (or rename) that container to be able to reuse that name.
See 'docker run --help'.
[check-node-versions-samples] Docker container 12-container encountered an error
[check-node-versions-samples] Started running the docker container 14-container
[check-node-versions-samples] Using node v14.17.3 to install dependencies

I think the fix is as easy as a conditional or an added filter to exclude empty strings but did not have time to test it

@maorleger maorleger added Client This issue points to a problem in the data-plane of the library. dev-tool Issues related to the Azure SDK for JS dev-tool labels Jul 29, 2021
@ramya-rao-a ramya-rao-a added this to the Backlog milestone Jul 30, 2021
@deyaaeldeen deyaaeldeen modified the milestones: Backlog, [2021] August Jul 30, 2021
openapi-sdkautomation bot pushed a commit to AzureSDKAutomation/azure-sdk-for-js that referenced this issue Jan 6, 2022
Web ant95 2021 03 01 (Azure#16506)

* Adds base for updating Microsoft.Web from version stable/2021-02-01 to version 2021-03-01

* Updates readme

* Updates API version in new specs and examples

* Re-add Microsoft.CertificateRegistration and Microsoft.DomainRegistration APIs since they do not get pulled in by OpenApiHub (Azure#15917)

* Introduce enterpriseGradeCdnStatus to StaticSites.json (Azure#16080)

* Update StaticSites.json

* Update StaticSites.json

* Onedeploy API swapper spec (Azure#15985)

* Onedeploy API swapper spec

* Adding onedeploy custom keyword

* Formatting onedeploy api indentation

Formatting onedeploy api indentation

* prettifier

Co-authored-by: Calvin Chan <calvinch4n@gmail.com>

* Fix status codes for syncfunctiontriggers (Azure#16413)

* Add GET endpoint at /config/authsettingsv2 for Microsoft.Web (Azure#16427)

* Add GET endpoint at /config/authsettingsv2 for Microsoft.Web

* Fix duplicate operation ids

* Swagger for ASD Transfer out (Azure#16000)

* Add domain transfer out to swagger

* Prettifier

* Add 202 response for webapp restart

* Add certificate listHostnameBindingsOfCertificate

* Formatting

* Swagger for listHostnameBindings endpoint (Azure#16516)

* Swagger for listHostnameBindings endpoint

* Re-add Microsoft.CertificateRegistration and Microsoft.DomainRegistration APIs since they do not get pulled in by OpenApiHub (Azure#15917)

* ops

Co-authored-by: Naveed Aziz <naveeda@microsoft.com>

* User/jennylaw/containerapp (Azure#16657)

* Pre-Prettier-commit

* Adding missing file

* Prettier fixes

* Add missing definitions

* Fix intendation in readme.md

* add suppressions

* Add custom hostname sites endpoint (Azure#16745)

* Add custom hostname sites endpoint

* Fix models

* Swagger Fixes for Container App, KubeEnvironments spec (Azure#16793)

* Pre-Prettier-commit

* Adding missing file

* Prettier fixes

* Add missing definitions

* Fix intendation in readme.md

* add suppressions

* Fix Kube Environments 2021-03-01 contract + add list secrets api to Container Apps Swagger

* Fix sercret read property

* Prettier fix

* Model fix

* Prettier Fix #2

Co-authored-by: Jenny Lawrance <jennylaw@microsoft.com>

* Add long running extension for restart (Azure#16791)

* Remove unused API from ANT95 swagger (Azure#16901)

* Address PR comments (Azure#17019)

* Fixing PR comments (Azure#17127)

* Remove Certificate Hostname bindings API (Azure#17204)

* Remove Certificate Hostname bindings API

* Remove examples file as well

Co-authored-by: mkarmark <mikarmar@microsoft.com>
Co-authored-by: SatishRanjan <SatishRanjan@users.noreply.github.com>
Co-authored-by: Calvin Chan <calvinch4n@gmail.com>
Co-authored-by: Connor McMahon <comcmaho@microsoft.com>
Co-authored-by: JennyLawrance <jennylaw@microsoft.com>
Co-authored-by: Sanchit Mehta <sanchit.mehta602@gmail.com>
@github-actions github-actions bot locked and limited conversation to collaborators Apr 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Client This issue points to a problem in the data-plane of the library. dev-tool Issues related to the Azure SDK for JS dev-tool
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants