Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

machinelearning - cspell found spelling errors #17209

Closed
danieljurek opened this issue Aug 26, 2021 · 1 comment
Closed

machinelearning - cspell found spelling errors #17209

danieljurek opened this issue Aug 26, 2021 · 1 comment
Labels
Client This issue points to a problem in the data-plane of the library. EngSys This issue is impacting the engineering system.

Comments

@danieljurek
Copy link
Member

danieljurek commented Aug 26, 2021 •
edited
Loading

Spell check scanning of machinelearning detected spelling errors. This service directory is opted out of PR spell checking in PR #17142 to keep merges unblocked.

What to do

  1. Ensure Node.js is installed (https://nodejs.org/en/download/). This will include npx
  2. Delete the service's entry in .vscode/cspell.json's ignorePaths field. It will look like: sdk/machinelearning/**/*. You need to do this to enable checking the files.
  3. From the root of the repo run spell check using npx cspell lint --config '.vscode/cspell.json' --no-must-find-files "sdk/machinelearning/**"
  4. Fix detections according to http://aka.ms/azsdk/engsys/spellcheck use the "False positives" section to fix false positives
  5. Check in changes (including the change to .vscode/cspell.json where the ignorePaths is updated to remove the entry for this service.). You may need to run git add -f .vscode/cspell.json to force adding the changes to the file in git.

Spell checking output

/home/djurek/azure-sdk-for-js/sdk/machinelearning/arm-commitmentplans/src/models/index.ts:54:22 - Unknown word (capabilites)
/home/djurek/azure-sdk-for-js/sdk/machinelearning/arm-webservices/src/models/index.ts:183:28 - Unknown word (Isnullable)
/home/djurek/azure-sdk-for-js/sdk/machinelearning/arm-webservices/src/models/index.ts:186:6 - Unknown word (Isnullable)
/home/djurek/azure-sdk-for-js/sdk/machinelearning/arm-webservices/src/models/index.ts:188:28 - Unknown word (Isordered)
/home/djurek/azure-sdk-for-js/sdk/machinelearning/arm-webservices/src/models/index.ts:191:6 - Unknown word (Isordered)
/home/djurek/azure-sdk-for-js/sdk/machinelearning/arm-webservices/src/models/mappers.ts:217:10 - Unknown word (Isnullable)
/home/djurek/azure-sdk-for-js/sdk/machinelearning/arm-webservices/src/models/mappers.ts:218:31 - Unknown word (isnullable)
/home/djurek/azure-sdk-for-js/sdk/machinelearning/arm-webservices/src/models/mappers.ts:223:10 - Unknown word (Isordered)
/home/djurek/azure-sdk-for-js/sdk/machinelearning/arm-webservices/src/models/mappers.ts:224:31 - Unknown word (isordered)
@danieljurek danieljurek added the Client This issue points to a problem in the data-plane of the library. label Aug 26, 2021
@ramya-rao-a ramya-rao-a added the EngSys This issue is impacting the engineering system. label Aug 26, 2021
@ramya-rao-a
Copy link
Contributor

All spell check errors are for an auto generated package and we don't intend to make any fixes for such packages

openapi-sdkautomation bot pushed a commit to AzureSDKAutomation/azure-sdk-for-js that referenced this issue Feb 14, 2022
@norshtein
CodeGen from PR 17814 in Azure/azure-rest-api-specs
4cff884 
New review request for Microsoft.ContainerService to add version 2022-01-01 (Azure#17814)

* Adds base for updating Microsoft.ContainerService from version stable/2021-10-01 to version 2022-01-01

* Updates readme

* Updates API version in new specs and examples

* Update readme to help generate SDK (Azure#17371)

* update readme to help generate SDK

* update readme

* Support query parameter 'format' in listClusterUserCredential handler (Azure#17209)

* Support query parameter 'format' in listClusterUserCredential handler

* Add kubelogin to custom words

* Fix enum lint

* Fix typo

* Fix typo

* List admin credential should not have format parameter

* Add adminUsers in aadprofile (Azure#17402)

* Revert "Add adminUsers in aadprofile (Azure#17402)" (Azure#17523)

This reverts commit 1d8f262848ad55df67f60321e2ccc1232c7f746b.

* fix conflict (Azure#17623)

Co-authored-by: Tongyao Si <tosi@microsoft.com>
@github-actions github-actions bot locked and limited conversation to collaborators Apr 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Client This issue points to a problem in the data-plane of the library. EngSys This issue is impacting the engineering system.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@danieljurek @ramya-rao-a