Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ESlint errors for web-pubsub-express package #17300

Closed
ramya-rao-a opened this issue Aug 27, 2021 · 1 comment · Fixed by #17962
Closed

Fix ESlint errors for web-pubsub-express package #17300

ramya-rao-a opened this issue Aug 27, 2021 · 1 comment · Fixed by #17962
Assignees
Labels
Client This issue points to a problem in the data-plane of the library. WebPubSub

Comments

@ramya-rao-a
Copy link
Contributor

We have the linter enabled for the @azure/web-pubsub-express package, and have a quite a few linter errors to fix

This issue is to ensure that we fix the these errors so that we future regressions can be found in CI. Following are the steps to run ESLint and reproduce this issue.

Set up your dev environment if not already done so as mentioned here

  • Go to <repo root>/sdk/web-pubsub/web-pubsub-express in your terminal
  • Run rushx lint. This will generate an html report with name ending with lintReport.html in the same folder
  • Fix one or more of the linter errors in the html report, and send a PR!

Once all linter errors are fixed, update the lint script in the package.json file to remove the below so that any new linter errors would fail the CI

-f html -o <package name>-lintReport.html || exit 0

@ghost ghost added the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Aug 27, 2021
@ramya-rao-a ramya-rao-a added Client This issue points to a problem in the data-plane of the library. WebPubSub labels Aug 27, 2021
@ghost ghost removed the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Aug 27, 2021
@ramya-rao-a
Copy link
Contributor Author

@vicancy In #17301, we have fixed quite a few of these errors that are straightforward and did not need any context on the source code. Please take a look at the rest of the linter errors and fix at them the earliest

@ramya-rao-a ramya-rao-a added this to the [2021] October milestone Aug 28, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Apr 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Client This issue points to a problem in the data-plane of the library. WebPubSub
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants