Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Web PubSub Express] Fix ESLint errors #17947

Closed
jeremymeng opened this issue Sep 29, 2021 · 1 comment
Closed

[Web PubSub Express] Fix ESLint errors #17947

jeremymeng opened this issue Sep 29, 2021 · 1 comment
Labels
Client This issue points to a problem in the data-plane of the library. WebPubSub

Comments

@jeremymeng
Copy link
Member

jeremymeng commented Sep 29, 2021 •
edited
Loading

We should

  1. fix ESLint errors for each of them
  2. remove the -f html -o recorder-lintReport.html || exit 0 part from their package.json
@ghost ghost added the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Sep 29, 2021
@jeremymeng jeremymeng added Client This issue points to a problem in the data-plane of the library. WebPubSub labels Sep 29, 2021
@ghost ghost removed the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Sep 29, 2021
@jeremymeng jeremymeng mentioned this issue Sep 29, 2021
Closed
8 tasks
@jeremymeng
Copy link
Member Author

jeremymeng commented Sep 30, 2021 •
edited
Loading

closing in favor of #17300

openapi-sdkautomation bot pushed a commit to AzureSDKAutomation/azure-sdk-for-js that referenced this issue Apr 8, 2022
@KacieKK @azaslonov
@ygrik @msyyc
CodeGen from PR 18478 in Azure/azure-rest-api-specs
ca8562e 
New Api-Version onboarding 2021-12-01-preview (Azure#18478)

* Adding 2021-12-01-preview as a copy of 2021-08-01

* Readme update

* Updating version in the 2021-12-01-preview folder

* update description for keyvault contract (Azure#17150)

Co-authored-by: Kacie Kang <jikang@microsoft.com>

* fix for the last cherry pick (06d2de8)

* fixing readme again

* APIM Policy fragments (Azure#16403)

* Adding the policy fragments spec

* Formatting

* Updating descriptions

* PolicyFragmentIdParameter as a string

* ID validation

* Adding fragment description

* Adding policy fragment format

* Adding raw xml format

* Addinga 202 response for creating/updating

* Generalising the resource collection

* formatting

* Moving everything to 2021-12-01

* version fix

* Adding pagination params. Generalising the IdParam

* Adding missing fields, fixing id param name

* Removing link formats. Fixing format param name

* POST list references

* name filter now supports "contains"

* PUT is always async

* Fixing header location url

* PUT can now return 200 and 201

* Adding more OData query support. Fixing examples.

* Resolving the cross breaking change

Co-authored-by: Milan Zolota <mizolota@microsoft.com>

* Added CORS and CSP configuration resources (Azure#16822)

* Added CORS and CSP settings resources.

* Added missing definitions.

* Added suppression of R4009 for apimportalsettings.json.

* Ran Prettier.

* Renamed definitions.

* Fixed references.

* Updated examples.

* Reversed change.

* Created new resource for portal settings.

* Added list example.

* Added missing collection contract.

* Added missing example. Cleaned up old ones.

* Fixed references.

* Fixed examples

* Fixed version.

* Added custom words. Fixed linting.

* Fixes.

* Fixes.

* Fixes.

* Fixes.

* Fixes.

* Fixes.

* Fixes.

* Fixes.

* Fixes.

* Fixes.

* Fixes

* Fixes.

* Fixes.

* Fixes

* Fixes

* Removed conflicting constraint.

* Updated readme.go.md.

* Reverted removing the restriction.

* Revert "Reverted removing the restriction."

This reverts commit 72d070f6ccc8231e4d4c9f22ac3a9c3090a545aa.

* Removed duplicate.

* Addressing PR comments.

* Adjusted reportUri property type in CSP config contract. (Azure#17947)

* Added missing body parameter description for content type resource. (Azure#18036)

* Igo/msal client version (Azure#17866)

* Added clientLibrary property to IdentityProvider

* fixed length for clientLibrary property

* Model validation fixes

* moved changes for clientLibrary property to the right spec file

* Update readme.md

Co-authored-by: Milan Zolota <mizolota@microsoft.com>
Co-authored-by: Kacie <35987382+KacieKK@users.noreply.github.com>
Co-authored-by: Kacie Kang <jikang@microsoft.com>
Co-authored-by: Alexander Zaslonov <zaslonov.alexander@gmail.com>
Co-authored-by: Igor O <ygrik@hotmail.com>
Co-authored-by: Yuchao Yan <yuchaoyan@microsoft.com>
@github-actions github-actions bot locked and limited conversation to collaborators Apr 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Client This issue points to a problem in the data-plane of the library. WebPubSub
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jeremymeng