Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ESLint Plugin] Add a ts-config-include rule #18514

Closed
jeremymeng opened this issue Nov 3, 2021 · 0 comments · Fixed by #18632
Closed

[ESLint Plugin] Add a ts-config-include rule #18514

jeremymeng opened this issue Nov 3, 2021 · 0 comments · Fixed by #18632
Labels
Client This issue points to a problem in the data-plane of the library. eslint plugin help wanted This issue is tracking work for which community contributions would be welcomed and appreciated

Comments

@jeremymeng
Copy link
Member

jeremymeng commented Nov 3, 2021 •
edited
Loading

We should ensure that the individual package's tsconfig.json file include source, tests and samples

This tracks the work to add a rule for verifying the value of "include" contains "src/**/*.ts", "test/**/*.ts", and "samples-dev/**/*.ts".

Code pointers for anyone wanting to fix this:
@jeremymeng jeremymeng added Client This issue points to a problem in the data-plane of the library. eslint plugin help wanted This issue is tracking work for which community contributions would be welcomed and appreciated labels Nov 3, 2021
@WeiJun428 WeiJun428 mentioned this issue Nov 11, 2021
Merged
deyaaeldeen pushed a commit that referenced this issue Nov 18, 2021
@WeiJun428
[ESLint Plugin] Add a ts-config-include rule #18514 (#18632)
5a68b0e 
* added ts-config-include to src/rules

* added ts-config-include to tests/rules

* added new rules ts-config-include

* Create ts-config-include.md

* run rushx format to fix README.md, ts-config-include.ts, and ts-package-json-engine-is-present.ts

* Fixed the broken README.md

* Fixed the broken README.md 2

* Revert prettier formatting on ts-package-json-engine-is-present.ts

* simplified checking and fixed wording in src/rules/ts-config-include.ts
azure-sdk pushed a commit to azure-sdk/azure-sdk-for-js that referenced this issue Apr 12, 2022
@akvmsft @priyadarshi-msft @mshrivastavamsft
CodeGen from PR 18514 in Azure/azure-rest-api-specs
720ade9 
[Azure Data Factory] Support rest-based connectors in ADF (Azure#18514)

* Updating Dataworld in custom words file

* Updating Linkedservice details with Dataworld information

* Update LinkedService.json

* Asana Swagger changes

* swagger changes for appfigures

* Update LinkedService.json

* Twilio linked service changes for datafactory

* Synapse linked service changes for Twilio

* Twilio custom-words.txt change

* Resolving conflicts

* removed extra comma

Co-authored-by: Aravind Reddy <akv@microsoft.com>
Co-authored-by: Priyadarshi Ghosh <prgh@microsoft.com>
Co-authored-by: mshrivastavamsft <103027908+mshrivastavamsft@users.noreply.github.com>
@github-actions github-actions bot locked and limited conversation to collaborators Apr 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Client This issue points to a problem in the data-plane of the library. eslint plugin help wanted This issue is tracking work for which community contributions would be welcomed and appreciated
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[ESLint Plugin] Add a ts-config-include rule #18514 WeiJun428/azure-sdk-for-js
1 participant
@jeremymeng