Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[JS] [Event Hub] API Review based on Service Bus review #1910

Closed
jeremymeng opened this issue Apr 1, 2019 · 2 comments
Closed

[JS] [Event Hub] API Review based on Service Bus review #1910

jeremymeng opened this issue Apr 1, 2019 · 2 comments
Labels
Client This issue points to a problem in the data-plane of the library. Event Hubs

Comments

@jeremymeng
Copy link
Member

Since Event Hub has many in common with Service Bus, API review feedback for Service Bus in #1481 also apply to Event Hub API. This work item tracks what we can address for Event Hub based on the feedback to Service Bus API.
@jeremymeng jeremymeng self-assigned this Apr 1, 2019
@jeremymeng jeremymeng added Client This issue points to a problem in the data-plane of the library. Event Hubs and removed triage labels Apr 1, 2019
@jeremymeng jeremymeng mentioned this issue Apr 1, 2019
Closed
@jeremymeng
Copy link
Member Author

Also consider refactorings that have been done to Service Bus code, even not resulted from API reviews.

This was referenced Apr 1, 2019
Closed
Closed
@AlexGhiondea AlexGhiondea changed the title [Event Hub] Pre Api Reviews [JS] [Event Hub] API Review Apr 3, 2019
@ramya-rao-a ramya-rao-a removed the Epic label May 3, 2019
@ramya-rao-a
Copy link
Contributor

Also consider refactorings that have been done to Service Bus code, even not resulted from API reviews.

#1331, #1356, #1911, #2688 are tracking such work.

Logged #2718 to track the review of user facing apis specific to Event Hubs

@ramya-rao-a ramya-rao-a changed the title [JS] [Event Hub] API Review [JS] [Event Hub] API Review based on Service Bus review May 6, 2019
azure-sdk pushed a commit that referenced this issue Aug 17, 2021
@heaths @azure-sdk
Attempt to purge all vaults, managed HSMs
8092c35 
Reverts #1910. Vaults and managed HSMs are automatically purged on their purge date. The point was to purge them daily to preserve capacity. The default purge date is +90 days.
azure-sdk pushed a commit that referenced this issue Aug 18, 2021
@heaths @azure-sdk
Attempt to purge all vaults, managed HSMs
398afbc 
Reverts #1910. Vaults and managed HSMs are automatically purged on their purge date. The point was to purge them daily to preserve capacity. The default purge date is +90 days.
azure-sdk added a commit that referenced this issue Aug 18, 2021
@azure-sdk @heaths
Sync eng/common directory with azure-sdk-tools for PR 1912 (#16972)
c2a26ac 
* Attempt to purge all vaults, managed HSMs

Reverts #1910. Vaults and managed HSMs are automatically purged on their purge date. The point was to purge them daily to preserve capacity. The default purge date is +90 days.

* Add timeout and more logging

* Pass required -Resource

* Fix log message

* Ensure the $Resource is correctly captured

Added comment to new code explaining why, since ScriptBlock.GetNewClosure() is not working as expected.

* Add -ErrorAction to Receive-Job

Worked without terminating when run locally, but failed on the first error in the AzDO agent.

* Use $using:r instead of creating ScriptBlock

More idiomatic for passing ScriptBlocks to jobs.

* Resolve PR feedback

* Change default DeleteAfterHours to 120

Resolves #1917

* Use the Az cmdlets built-in -AsJob

Co-authored-by: Heath Stewart <heaths@microsoft.com>
@github-actions github-actions bot locked and limited conversation to collaborators Apr 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Client This issue points to a problem in the data-plane of the library. Event Hubs
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jeremymeng @AlexGhiondea @ramya-rao-a