dataFlow is missing on DataFactory Activity responses

[btimperman-pantomath]

• Package Name: @azure/arm-datafactory
• Package Version: 10.10.2
• Operating system: Linux
• nodejs
  • version: 14.21.2
• typescript
  • version: 4.6.3

Describe the bug
The ActivityUnion objects nested in the PipelineResource object returned by dataFactoryClient.pipelines.listByFactory() are missing the dataFlow field, even though this is present in the REST API JSON response.

To Reproduce
Steps to reproduce the behavior:

1. Create an ADF pipeline with an activity that executes a Data Flow.
2. Call dataFactoryClient.pipelines.listByFactory().
3. The ActivityUnion representing the above activity will have an undefined dataFlow field.

Expected behavior
The dataFlow field should be populated with a DataFlowReference.

Additional context
This happens because the serializedName field in sdk/datafactory/arm-datafactory/src/models/mappers.ts has a typo pointing to an incorrect field on the JSON response. The correct field on the REST API JSON response is typeProperties.dataflow not typeProperties.dataFlow.

[qiaozha]

From the swagger https://github.com/Azure/azure-rest-api-specs/blob/main/specification/datafactory/resource-manager/Microsoft.DataFactory/stable/2018-06-01/entityTypes/Pipeline.json#L7390-L7393, it is called dataFlow. I guess there's a mismatch between the service backend and their rest api specs.

[ghost]

Thanks for the feedback! We are routing this to the appropriate team for follow-up. cc @Jingshu923, @zhangyd2015, @Frey-Wang.

Issue Details

---

• Package Name: @azure/arm-datafactory
• Package Version: 10.10.2
• Operating system: Linux
• nodejs
  • version: 14.21.2
• typescript
  • version: 4.6.3

Describe the bug
The ActivityUnion objects nested in the PipelineResource object returned by dataFactoryClient.pipelines.listByFactory() are missing the dataFlow field, even though this is present in the REST API JSON response.

To Reproduce
Steps to reproduce the behavior:

1. Create an ADF pipeline with an activity that executes a Data Flow.
2. Call dataFactoryClient.pipelines.listByFactory().
3. The ActivityUnion representing the above activity will have an undefined dataFlow field.

Expected behavior
The dataFlow field should be populated with a DataFlowReference.

Additional context
This happens because the serializedName field in sdk/datafactory/arm-datafactory/src/models/mappers.ts has a typo pointing to an incorrect field on the JSON response. The correct field on the REST API JSON response is typeProperties.dataflow not typeProperties.dataFlow.

Author:	btimperman-pantomath
Assignees:	qiaozha
Labels:	bug, customer-reported, Mgmt, Service Attention, Data Factory
Milestone:	-

[MaryGao]

@btimperman-pantomath Could you share the type you refered in the list operation in ActivityUnion?

We tested in our side and found the dataFlow is not undefined and here is our traffic recording file.

azure-sdk-for-js/sdk/datafactory/arm-datafactory/test/datafactory_examples.spec.ts

Lines 291 to 297 in 4f6c4ee

	for await (let item of client.pipelines.listByFactory(resourceGroup, factoryName)) {
	resArray.push(item);
	}
	assert.equal(resArray.length, 1);
	assert.equal(resArray[0].activities?.length, 1);
	assert.equal(resArray[0].activities![0].type, "ExecuteWranglingDataflow");
	assert.equal(resArray[0].activities![0].dataFlow.type, "DataFlowReference");

Please notice the property dataFlow is only valid for part of activities like ExecuteWranglingDataflow

azure-sdk-for-js/sdk/datafactory/arm-datafactory/src/models/index.ts

Lines 7430 to 7436 in 4f6c4ee

	export interface ExecuteWranglingDataflowActivity extends Activity {
	/** Polymorphic discriminator, which specifies the different types this object can be */
	type: "ExecuteWranglingDataflow";
	/** Activity policy. */
	policy?: ActivityPolicy;
	/** Data flow reference. */
	dataFlow: DataFlowReference;

.

[ghost]

Hi, we're sending this friendly reminder because we haven't heard back from you in a while. We need more information about this issue to help address it. Please be sure to give us your input within the next 7 days. If we don't hear back from you within 14 days of this comment the issue will be automatically closed. Thank you!