-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
@azure/core-xml fails to build with devDependency @types/trusted-types@2.0.3 #24872
Labels
Comments
mikeharder
added a commit
to mikeharder/azure-sdk-for-js
that referenced
this issue
Feb 15, 2023
- Workaround for Azure#24872
mikeharder
added a commit
to mikeharder/azure-sdk-for-js
that referenced
this issue
Feb 17, 2023
We can add |
jeremymeng
added a commit
to jeremymeng/azure-sdk-for-js
that referenced
this issue
May 9, 2023
…allback Fixes issue Azure#24872.
jeremymeng
added a commit
that referenced
this issue
May 9, 2023
…allback (#25813) ### Packages impacted by this PR `@azure/core-xml`, `@azure/core-http` ### Issues associated with this PR Fixes issue #24872. ### Describe the problem that is addressed by this PR Upgrading to @trusted-types v2.0.3 caused compilation error. While it is breaking, it surfaces an issue that we can address by adding proper parameter type. ### What are the possible designs available to address the problem? If there are more than one possible design, why was the one in this PR chosen? Pinning to v2.0.2 which isn't desirable as we want to stay on latest dependency versions.
minhanh-phan
pushed a commit
to minhanh-phan/azure-sdk-for-js
that referenced
this issue
Jun 12, 2023
…allback (Azure#25813) ### Packages impacted by this PR `@azure/core-xml`, `@azure/core-http` ### Issues associated with this PR Fixes issue Azure#24872. ### Describe the problem that is addressed by this PR Upgrading to @trusted-types v2.0.3 caused compilation error. While it is breaking, it surfaces an issue that we can address by adding proper parameter type. ### What are the possible designs available to address the problem? If there are more than one possible design, why was the one in this PR chosen? Pinning to v2.0.2 which isn't desirable as we want to stay on latest dependency versions.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
@azure/core-xml
builds fine with@types/trusted-types@2.0.2
. However, with@types/trusted-types@2.0.3
, it fails with the following error:azure-sdk-for-js/sdk/core/core-xml/src/xml.browser.ts
Lines 19 to 24 in b2e7b22
I believe the root cause is DefinitelyTyped/DefinitelyTyped#64360.
Do you think this is a breaking change in
@types/trusted-types
that should be reverted?If not, I think we will need to:
@types/trusted-types@^2.0.0
to@types/trusted-types@^2.0.3
. Note that both@azure/core-xml
and@azure/core-http
have a dep on@types/trusted-types
.The text was updated successfully, but these errors were encountered: