Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Azure WebPubSub Client SDK Protobuf Sample Issue #25703

Closed
zzhxiaofeng opened this issue Apr 28, 2023 · 7 comments
Closed

Azure WebPubSub Client SDK Protobuf Sample Issue #25703

zzhxiaofeng opened this issue Apr 28, 2023 · 7 comments
Assignees
@vicancy @zackliu
Labels
Client This issue points to a problem in the data-plane of the library. Docs test-manual-pass WebPubSub

Comments

@zzhxiaofeng
Copy link
Contributor

Section link1, link2.
Screenshot 2023-04-28 180655
GetImage (5)
Reason:
Cannot find module './src/index-minimal'
GetImage (6)

@joheredi, @bterlson for notification.
@github-actions github-actions bot added the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Apr 28, 2023
@v-xuto v-xuto added Client This issue points to a problem in the data-plane of the library. Docs needs-team-triage Workflow: This issue needs the team to triage. test-manual-pass WebPubSub labels Apr 28, 2023
@github-actions github-actions bot removed the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Apr 28, 2023
@xirzec xirzec removed the needs-team-triage Workflow: This issue needs the team to triage. label Apr 28, 2023
@v-jiaodi
Copy link
Member

v-jiaodi commented Jun 1, 2023

@vicancy Please help check and resolve this issue.

@v-xuto
Copy link
Member

v-xuto commented Aug 3, 2023

@vicancy Regarding this issue, what is the current progress?

@vicancy
Copy link
Member

vicancy commented Aug 15, 2023

Thanks for reporting this, @zackliu could you help check?

@v-xuto
Copy link
Member

v-xuto commented Sep 14, 2023

@zackliu Any progress about this issue?

@zackliu zackliu mentioned this issue Sep 22, 2023
Merged
3 tasks
jeremymeng pushed a commit that referenced this issue Sep 26, 2023
@zackliu
Fix the bug that commonjs doesn't work for @azure/web-pubsub-client-p…
7fbc630 
…rotobuf (#27209)

### Packages impacted by this PR
@azure/web-pubsub-client-protobuf

### Issues associated with this PR
#25703

### Describe the problem that is addressed by this PR
As protobufjs is purely commonjs type but rollup bundle didn't add
commonjs support. So only file in `dist-esm/` works but in `dist`
doesn't.

### Are there test cases added in this PR? _(If not, why?)_
Test already added `cjs()` plugin in bundle, so it works.
@zzhxiaofeng
Copy link
Contributor Author

@zackliu The issue still exists when I run the samples based on PR #27209. Do I need some additional configurations to run the samples?

@zackliu
Copy link
Member

zackliu commented Oct 7, 2023

@zzhxiaofeng The same error? These samples depend on released package. I haven't released a new version upon this commit. If you need to have a try, you can use npm pack to build a local package and use file reference in the package.json

@zzhxiaofeng
Copy link
Contributor Author

zzhxiaofeng commented Oct 7, 2023 •
edited
Loading

@zackliu Ok, I have a try and the issue does not exist by your way. Thank you very much.

@v-xuto v-xuto closed this as completed Jul 3, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Oct 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@vicancy vicancy

@zackliu zackliu

Labels
Client This issue points to a problem in the data-plane of the library. Docs test-manual-pass WebPubSub
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@xirzec @vicancy @zackliu @zzhxiaofeng @v-xuto @v-jiaodi