The keyword expires does not work in keyvault secret library

[comorekf]

• Package Name: keyvault-secrets
• Package Version: 4.7.0
• Operating system: windows
• nodejs
  • version: 18.16.1
• browser
  • name/version:
• typescript
  • version: 4.4.2
• Is the bug related to documentation in
  • README.md
  • source code documentation
  • SDK API docs on https://docs.microsoft.com
  • https://learn.microsoft.com/en-us/javascript/api/overview/azure/keyvault-secrets-readme?view=azure-node-latest

Describe the bug
A clear and concise description of what the bug is.
When setting a KV secret with expiry date the attribute is wrongly named in the documentation. expires does have no effect while expiresOn works.
To Reproduce
Steps to reproduce the behavior:

client.setSecret(secretName, "automated", {
                expires: expire,
            });

vs

client.setSecret(secretName, "automated", {
                expiresOn: expire,
            });

Expected behavior
Either expires work as described in the documentation or the documentation is updated.

Screenshots
Not applicable.

Additional context
TS library

[xirzec]

Thanks @comorekf for reporting!

It looks like the detailed API docs have expiresOn: https://learn.microsoft.com/en-us/javascript/api/%40azure/keyvault-secrets/secretproperties?view=azure-node-latest

But the README is not updated:

azure-sdk-for-js/sdk/keyvault/keyvault-secrets/README.md

Line 208 in cd8e166

- `expires`: A given date after which the secret value cannot be retrieved.

[timovv]

Thanks for reporting! I have made a PR with the fix. I'm surprised this wasn't caught earlier!