Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Key Vault - Keys] Package is always re-built even if no changes #27106

Closed
mikeharder opened this issue Sep 13, 2023 · 0 comments · Fixed by #27266
Closed

[Key Vault - Keys] Package is always re-built even if no changes #27106

mikeharder opened this issue Sep 13, 2023 · 0 comments · Fixed by #27266
Assignees
@timovv
Labels
Client This issue points to a problem in the data-plane of the library. EngSys This issue is impacting the engineering system. KeyVault

Comments

@mikeharder
Copy link
Member

Repro Steps

  1. Start with a clean enlistment (e.g. run git clean -xdf from repo root)
  2. rush install
  3. rush build --to @azure/keyvault-keys
    • Should build 16 packages
  4. rush build --to @azure/keyvault-keys

Expected

No packages should need to be rebuilt, since there have been no changes to the repo.

Actual

@azure/keyvault-keys is rebuilt, but all other packages are not:

==[ SKIPPED: 15 operations ]===================================================

These operations were already up to date:
  @azure/abort-controller
  @azure/dev-tool
  @azure/eslint-plugin-azure-sdk
  @azure/core-client
  @azure/core-auth
  @azure/core-util
  @azure/core-rest-pipeline
  @azure/core-tracing
  @azure/logger
  @azure/core-xml
  @azure/core-lro
  @azure/test-utils
  @azure-tools/test-recorder
  @azure/core-paging
  @azure-tools/test-credential

==[ SUCCESS WITH WARNINGS: 1 operation ]=======================================

--[ WARNING: @azure/keyvault-keys ]-------------------------[ 14.87 seconds ]--
@github-actions github-actions bot added the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Sep 13, 2023
@xirzec xirzec added EngSys This issue is impacting the engineering system. Client This issue points to a problem in the data-plane of the library. KeyVault labels Sep 14, 2023
@github-actions github-actions bot removed the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Sep 14, 2023
timovv added a commit to timovv/azure-sdk-for-js that referenced this issue Sep 27, 2023
@timovv
[keyvault] Fix keyvault-keys build warnings
9a63f8d 
Fix browser bundling warnings by:
- Re-enabling Node polyfill for browser bundle
- Create browser mappings for Node-only tests which use
  `crypto.createHash`, which does not have a polyfill

Fixes Azure#27106
@timovv timovv mentioned this issue Sep 27, 2023
Merged
timovv added a commit that referenced this issue Oct 2, 2023
@timovv
[keyvault] Fix keyvault-keys build warnings (#27266)
de1f185 
### Issues associated with this PR

- Fixes #27106

### Describe the problem that is addressed by this PR
Fix browser bundling warnings by:

- Create browser mappings for Node-only tests which use
`crypto.createHash`, which does not have a polyfill
- Re-enabling Node polyfill for browser bundle

### Packages impacted by this PR

- `@azure/keyvault-keys`
@github-actions github-actions bot locked and limited conversation to collaborators Dec 31, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@timovv timovv

Labels
Client This issue points to a problem in the data-plane of the library. EngSys This issue is impacting the engineering system. KeyVault
Projects
Azure SDK for Key Vault
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[keyvault] Fix keyvault-keys build warnings timovv/azure-sdk-for-js
3 participants
@xirzec @timovv @mikeharder