-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[@azure/monitor-opentelemetry] - Requests with status code 304 are shown as failed in application insights #29398
Comments
Thanks for the feedback! We are routing this to the appropriate team for follow-up. cc @hectorhdzg @JacksonWeber @ramthi. |
@despgiat I'm not able to reproduce this situation of 304 status codes being shown as errors. Requests marked as response code 304 are being shown as I expect in the transaction blade when using your example code with an express server that returns a 304 response. Can you provide more information on where these 304 response codes are being returned from or more details for reproducing your scenario? Thanks! |
@JacksonWeber Guess I can chime in here. You can use this repo for repro. It was initially used for a different problem with application insights js sdk/azure otel distro, but has the same issue with 304's showing up under failures. You can find detailed steps for reproducing the scenario in the readme. For the setup - personally I used two ai resources (web client/api) in same workspace, however a shared one also works. |
@p-hlp Thank you for doing this work to repro. I'll recreate this scenario and work on debug as soon as I can. |
@JacksonWeber Are there any updates by chance? It's a bit of an annoying problem. Otherwise anything I could do on my side to support with getting this going? |
@p-hlp Apologies I haven't had much time to look into this earlier. Investigating this afternoon and I'll provide an update ASAP. |
…ard Metrics (#29957) ### Packages impacted by this PR @azure/monitor-opentelemetry ### Issues associated with this PR Fixes #29398 ### Describe the problem that is addressed by this PR Success/failure on standard metrics collection for dependencies and requests should follow the spec: < 400 is success ### What are the possible designs available to address the problem? If there are more than one possible design, why was the one in this PR chosen? ### Are there test cases added in this PR? _(If not, why?)_ Updated test cases that already use the dividing line between success/failure (status code 400) ### Checklists - [x] Added impacted package name to the issue description - [ ] Does this PR needs any fixes in the SDK Generator?** _(If so, create an Issue in the [Autorest/typescript](https://github.com/Azure/autorest.typescript) repository and link it here)_ - [x] Added a changelog (if necessary)
Describe the bug
Currently some requests are treated and shown as errors, e.g.
304
which is a redirect / cache-hit. The majority of the errors that we get are304
requests. Moreover, we don't get any information about these requests in application insights (in the first screenshot below you can see how the the dashboard looks like when the304
is clicked to reveal more information about the errors). Also, these requests are not shown as errors in transaction search, and when they are filtered (ex. by response code), they do not show in the failed requests graph anymore.To Reproduce
Our setup is similar to this example:
Expected behavior
The requests with status code
304
are not shown as errors in application insights.Screenshots
Additional context
We played around a bit and tried to set custom attributes to the http requests using a SpanEnrichingProcessor but it seems that no custom attributes could be added to these failed requests.
The text was updated successfully, but these errors were encountered: