Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[engsys] upgrade Eslint to v9 #29750

Closed
jeremymeng opened this issue May 17, 2024 · 1 comment
Closed

[engsys] upgrade Eslint to v9 #29750

jeremymeng opened this issue May 17, 2024 · 1 comment
Assignees
Labels
EngSys This issue is impacting the engineering system. eslint plugin

Comments

@jeremymeng
Copy link
Member

jeremymeng commented May 17, 2024

One of the notable breaking changes is the moving to Flat Config and dropping support for legacy config files. To upgrade to v9, we need to

  • update our eslint-plugin-azure-sdk to support Flat Config (eslint.config.{js,mjs})
  • migrate existing packages to use Flag Config
    • The changes need look easy enough to utilize automated transformation. Could use dev-tool admin list packages to apply the transformation for all packages in one go.
    • remove --ext command line option
  • modify codegen to adapt to changes
    • removing of --ext option for example

Issues

@github-actions github-actions bot added the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label May 17, 2024
@jeremymeng jeremymeng added EngSys This issue is impacting the engineering system. eslint plugin labels May 17, 2024
@jeremymeng jeremymeng self-assigned this May 17, 2024
@github-actions github-actions bot removed the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label May 17, 2024
jeremymeng added a commit that referenced this issue May 21, 2024
ESLint v9 drops support for legacy .eslintrc style configuration files.
To move to v9 we need to migrate to the new Flat Config files. This PR
adds support for Flat Config file and migrate cosmos and identity-broker
packages to use the flat config. Legacy config files are still
supported.

Some eslint plugins that we use don't support flat config yet so they
are disabled.

Related issue: #29750
@jeremymeng
Copy link
Member Author

Done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
EngSys This issue is impacting the engineering system. eslint plugin
Projects
None yet
Development

No branches or pull requests

1 participant